This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19442 ) Change subject: vty: Introduce support to set cpu-affinity and scheduler policy ...................................................................... Patch Set 3: Code-Review-1 (10 comments) https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c File src/vty/sched_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@89 PS3, Line 89: static bool proc_tid_exists(pid_t tid) one-line comment would be useful https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@103 PS3, Line 103: { inconsistent syntax. Other clauese have opening braces at end of line, this one doesn't. And if is a function below https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@117 PS3, Line 117: static bool proc_name_exists(const char *name, pid_t *res_pid) one-line summary https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@121 PS3, Line 121: char path[100]; why not PATH_MAX? https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@138 PS3, Line 138: if(entry->d_name[0] == '.') if... https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@147 PS3, Line 147: Last char contain a '\n', get rid of it */ : buf[rc-1] = '\0'; don't blindly assume what you read has a certain structure; test for it! https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@149 PS3, Line 149: buf buffer overflow: rc may be sizeof(buf) and you're writing beyond the end of the buffer here. https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@165 PS3, Line 165: static enum sched_vty_thread_id procname2pid(pid_t *res_pid, const char *str, bool applynow) one-line summary https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@218 PS3, Line 218: int my_sched_setaffinity(enum sched_vty_thread_id tid_type, pid_t pid, unsigned long mask) one lne summary https://gerrit.osmocom.org/c/libosmocore/+/19442/3/src/vty/sched_vty.c@230 PS3, Line 230: cpuset = CPU_ALLOC(64); blind assumption of 64 cores -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If76a4bd2cc7b3c7adf5d84790a944d78be70e10a Gerrit-Change-Number: 19442 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 29 Jul 2020 20:00:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200729/5b90e377/attachment.htm>