Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: replace istemplatekind with valueof

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19301 )


Change subject: MSC_ConnectionHandler: replace istemplatekind with valueof
......................................................................

MSC_ConnectionHandler: replace istemplatekind with valueof

The function f_establish_fully() and f_ass_patch_lcls() use the built in
TTCN3 function istemplatekind to check if the ass_tpl template is set to
omit by the caller. This seems not to work, lets use valueof instead.

Change-Id: I77272214301bc4982d8bcac64e09a0c679f038bb
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/19301/1

diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 7d8fce1..0697413 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -935,7 +935,7 @@
 /* patch an BSSMAP ASS REQ with LCLS related IEs, depending on g_params */
 function f_ass_patch_lcls(inout template (omit) PDU_BSSAP ass_tpl,
 			  inout template PDU_BSSAP ass_cpl) runs on MSC_ConnHdlr {
-	if (istemplatekind(ass_tpl, "omit")) {
+	if (not isvalue(ass_tpl)) {
 		return;
 	}
 	if (ispresent(g_pars.lcls.gcr)) {
@@ -1045,7 +1045,7 @@
 	}
 
 	/* bail out early if no assignment requested */
-	if (istemplatekind(ass_tpl, "omit")) {
+	if (not isvalue(ass_tpl)) {
 		return;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19301
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I77272214301bc4982d8bcac64e09a0c679f038bb
Gerrit-Change-Number: 19301
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200716/f367b92a/attachment.htm>