<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19301">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC_ConnectionHandler: replace istemplatekind with valueof<br><br>The function f_establish_fully() and f_ass_patch_lcls() use the built in<br>TTCN3 function istemplatekind to check if the ass_tpl template is set to<br>omit by the caller. This seems not to work, lets use valueof instead.<br><br>Change-Id: I77272214301bc4982d8bcac64e09a0c679f038bb<br>---<br>M bsc/MSC_ConnectionHandler.ttcn<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/19301/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index 7d8fce1..0697413 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -935,7 +935,7 @@</span><br><span> /* patch an BSSMAP ASS REQ with LCLS related IEs, depending on g_params */</span><br><span> function f_ass_patch_lcls(inout template (omit) PDU_BSSAP ass_tpl,</span><br><span>                       inout template PDU_BSSAP ass_cpl) runs on MSC_ConnHdlr {</span><br><span style="color: hsl(0, 100%, 40%);">-      if (istemplatekind(ass_tpl, "omit")) {</span><br><span style="color: hsl(120, 100%, 40%);">+      if (not isvalue(ass_tpl)) {</span><br><span>          return;</span><br><span>      }</span><br><span>    if (ispresent(g_pars.lcls.gcr)) {</span><br><span>@@ -1045,7 +1045,7 @@</span><br><span>    }</span><br><span> </span><br><span>        /* bail out early if no assignment requested */</span><br><span style="color: hsl(0, 100%, 40%);">- if (istemplatekind(ass_tpl, "omit")) {</span><br><span style="color: hsl(120, 100%, 40%);">+      if (not isvalue(ass_tpl)) {</span><br><span>          return;</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19301">change 19301</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19301"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I77272214301bc4982d8bcac64e09a0c679f038bb </div>
<div style="display:none"> Gerrit-Change-Number: 19301 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>