Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: replace istemplatekind with valueof

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Jul 16 15:33:55 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19301 )

Change subject: MSC_ConnectionHandler: replace istemplatekind with valueof
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19301/1/bsc/MSC_ConnectionHandler.ttcn 
File bsc/MSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19301/1/bsc/MSC_ConnectionHandler.ttcn@938 
PS1, Line 938: isvalue
> isvalue(v_template) returns true, if v_template contains concrete value or "omit"

So I am not sure if that's exactly what we need here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19301/1/bsc/MSC_ConnectionHandler.ttcn@942 
PS1, Line 942: ass_tpl.pdu.bssmap
... because you cannot access/reference fields of "omit".



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19301
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I77272214301bc4982d8bcac64e09a0c679f038bb
Gerrit-Change-Number: 19301
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Jul 2020 15:33:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200716/5a46c52b/attachment.htm>


More information about the gerrit-log mailing list