Change in libosmo-sccp[master]: Revert "fix memleaks in mtp_user_prim_cb()"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Wed Jan 8 19:24:29 UTC 2020


neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16770 )

Change subject: Revert "fix memleaks in mtp_user_prim_cb()"
......................................................................

Revert "fix memleaks in mtp_user_prim_cb()"

This reverts commit ffb248dd787eb854e049d990afc40f0e604268f2.

Reason for revert: ttcn-msc-tests fail, apparently there are lots more
xua_msg_free() in scrc_rx_mtp_xfer_ind_xua() that need to be dropped

Change-Id: I008bcb6d5bad9e6347e7cd670159816f51331189
---
M src/sccp_scoc.c
M src/sccp_user.c
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index e2768ea..7570764 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -1413,6 +1413,7 @@
 
 	/* sent to SCRC for transmission */
 	sccp_scrc_rx_scoc_conn_msg(inst, xua);
+	xua_msg_free(xua);
 }
 
 /* Generate a RELCO based in input arguments */
@@ -1450,6 +1451,7 @@
 
 	/* send to SCRC for transmission */
 	sccp_scrc_rx_scoc_conn_msg(inst, xua);
+	xua_msg_free(xua);
 }
 
 /* Generate a RLSD based in input arguments */
diff --git a/src/sccp_user.c b/src/sccp_user.c
index 49cc212..929445f 100644
--- a/src/sccp_user.c
+++ b/src/sccp_user.c
@@ -174,7 +174,6 @@
 		xua->mtp = omp->u.transfer;
 		/* hand this primitive into SCCP via the SCRC code */
 		rc = scrc_rx_mtp_xfer_ind_xua(inst, xua);
-		xua_msg_free(xua);
 		break;
 	default:
 		LOGP(DLSCCP, LOGL_ERROR, "Unknown primitive %u:%u receivd\n",

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16770
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I008bcb6d5bad9e6347e7cd670159816f51331189
Gerrit-Change-Number: 16770
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200108/a1ff3048/attachment.htm>


More information about the gerrit-log mailing list