Change in libosmo-sccp[master]: Revert "fix memleaks in mtp_user_prim_cb()"

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16770 )

Change subject: Revert "fix memleaks in mtp_user_prim_cb()"
......................................................................


Patch Set 1: Code-Review+2

This patch made all TTCN3 MSC_Test crash:
#4  0x00007fd41437101c in xua_msg_free (msg=<optimized out>) at xua_msg.c:58
No locals.
#5  0x00007fd414379385 in mtp_user_prim_cb (oph=0x61e000008768,
    ctx=<optimized out>) at sccp_user.c:177
        inst = <optimized out>
        omp = 0x61e000008768
        xua = 0x60d000021cf0
        rc = 0
#6  0x00007fd414370cbb in m3ua_rx_xfer (xua=0x60d000021e90,
    asp=0x61800000c8e0) at m3ua.c:586
        rctx = <optimized out>
        dh = <optimized out>
        as = <optimized out>
#7  m3ua_rx_msg (asp=asp at entry=0x61800000c8e0, msg=msg at entry=0x61e0000090e0)
    at m3ua.c:739
        xua = 0x60d000021e90
        err = 0x0
        rc = 0
#8  0x00007fd41438068b in xua_cli_read_cb (conn=0x6180000020e0)
    at osmo_ss7.c:1701
        ofd = 0x6180000020e0
        asp = 0x61800000c8e0
        msg = 0x61e0000090e0
        sinfo = {sinfo_stream = 1, sinfo_ssn = 0, sinfo_flags = 0,
          sinfo_ppid = 50331648, sinfo_context = 0, sinfo_timetolive = 0,
          sinfo_tsn = 2636227977, sinfo_cumtsn = 0, sinfo_assoc_id = 61}
        flags = 128
        rc = 56
        __func__ = "xua_cli_read_cb"
#9  0x00007fd414fcce43 in osmo_stream_cli_read (cli=0x6180000020e0)
    at stream.c:222
No locals.
#10 osmo_stream_cli_fd_cb (ofd=<optimized out>, what=1) at stream.c:311
        cli = 0x6180000020e0
        error = 384178024
        ret = <optimized out>
        len = 4
        __func__ = "osmo_stream_cli_fd_cb"
#11 0x00007fd4153fe0bf in osmo_fd_disp_fds (_eset=<optimized out>,
    _wset=<optimized out>, _rset=<optimized out>) at select.c:227
        flags = 1
        ufd = 0x6180000020e0
        tmp = 0x61400000e0a0
        work = 1
#12 _osmo_select_main (polling=0) at select.c:265
        readset = {__fds_bits = {0 <repeats 16 times>}}
        writeset = {__fds_bits = {0 <repeats 16 times>}}
        exceptset = {__fds_bits = {0 <repeats 16 times>}}
        rc = <optimized out>
        no_time = {tv_sec = 0, tv_usec = 0}
#13 0x00007fd4153fe776 in osmo_select_main_ctx (polling=<optimized out>)
    at select.c:291
        rc = <optimized out>
#14 0x0000559919ee5abc in main (argc=3, argv=0x7ffe36768b28) at msc_main.c:729
        rc = 0
        sccp_a = <error reading variable sccp_a (Cannot access memory at address 0xffffffffffffff80)>
        sccp_iu = <error reading variable sccp_iu (Cannot access memory at address 0xffffffffffffffc0)>


-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16770
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I008bcb6d5bad9e6347e7cd670159816f51331189
Gerrit-Change-Number: 16770
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 08 Jan 2020 19:23:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200108/23cfca6f/attachment.htm>