<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16770">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "fix memleaks in mtp_user_prim_cb()"<br><br>This reverts commit ffb248dd787eb854e049d990afc40f0e604268f2.<br><br>Reason for revert: ttcn-msc-tests fail, apparently there are lots more<br>xua_msg_free() in scrc_rx_mtp_xfer_ind_xua() that need to be dropped<br><br>Change-Id: I008bcb6d5bad9e6347e7cd670159816f51331189<br>---<br>M src/sccp_scoc.c<br>M src/sccp_user.c<br>2 files changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c</span><br><span>index e2768ea..7570764 100644</span><br><span>--- a/src/sccp_scoc.c</span><br><span>+++ b/src/sccp_scoc.c</span><br><span>@@ -1413,6 +1413,7 @@</span><br><span> </span><br><span>     /* sent to SCRC for transmission */</span><br><span>  sccp_scrc_rx_scoc_conn_msg(inst, xua);</span><br><span style="color: hsl(120, 100%, 40%);">+        xua_msg_free(xua);</span><br><span> }</span><br><span> </span><br><span> /* Generate a RELCO based in input arguments */</span><br><span>@@ -1450,6 +1451,7 @@</span><br><span> </span><br><span>   /* send to SCRC for transmission */</span><br><span>  sccp_scrc_rx_scoc_conn_msg(inst, xua);</span><br><span style="color: hsl(120, 100%, 40%);">+        xua_msg_free(xua);</span><br><span> }</span><br><span> </span><br><span> /* Generate a RLSD based in input arguments */</span><br><span>diff --git a/src/sccp_user.c b/src/sccp_user.c</span><br><span>index 49cc212..929445f 100644</span><br><span>--- a/src/sccp_user.c</span><br><span>+++ b/src/sccp_user.c</span><br><span>@@ -174,7 +174,6 @@</span><br><span>                 xua->mtp = omp->u.transfer;</span><br><span>            /* hand this primitive into SCCP via the SCRC code */</span><br><span>                rc = scrc_rx_mtp_xfer_ind_xua(inst, xua);</span><br><span style="color: hsl(0, 100%, 40%);">-               xua_msg_free(xua);</span><br><span>           break;</span><br><span>       default:</span><br><span>             LOGP(DLSCCP, LOGL_ERROR, "Unknown primitive %u:%u receivd\n",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16770">change 16770</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16770"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I008bcb6d5bad9e6347e7cd670159816f51331189 </div>
<div style="display:none"> Gerrit-Change-Number: 16770 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>