Change in osmo-sim-auth[master]: SIM.py: convert to Python 3 using 2to3

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

rousseau gerrit-no-reply at lists.osmocom.org
Wed Dec 16 16:30:06 UTC 2020


rousseau has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sim-auth/+/20903 )

Change subject: SIM.py: convert to Python 3 using 2to3
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> we shouldn't introduce changes here, as this code is copied from https://github.com/mitshell/card
> 
> So any changes should go in upstream, and then we should either convert to using mishell/card as a python module, or import it using git submodule, or git subtree or the like.

I reported the issue to https://github.com/mitshell/card/issues/7
But the problem is already fixed upstream.

osmo-sim-auth uses a very old copy/fork of https://github.com/mitshell/card
Maybe you should use a git submodule instead?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sim-auth/+/20903
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sim-auth
Gerrit-Branch: master
Gerrit-Change-Id: I1f972e308e14dbdbfc85892685682220a89f77fe
Gerrit-Change-Number: 20903
Gerrit-PatchSet: 1
Gerrit-Owner: rousseau <ludovic.rousseau+osmocom at free.fr>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 16 Dec 2020 16:30:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201216/020990c5/attachment.htm>


More information about the gerrit-log mailing list