<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">we shouldn't introduce changes here, as this code is copied from https://github.com/mitshell/card</p><p style="white-space: pre-wrap; word-wrap: break-word;">So any changes should go in upstream, and then we should either convert to using mishell/card as a python module, or import it using git submodule, or git subtree or the like.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I reported the issue to https://github.com/mitshell/card/issues/7<br>But the problem is already fixed upstream.</p><p style="white-space: pre-wrap; word-wrap: break-word;">osmo-sim-auth uses a very old copy/fork of https://github.com/mitshell/card<br>Maybe you should use a git submodule instead?</p><p><a href="https://gerrit.osmocom.org/c/osmo-sim-auth/+/20903">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sim-auth/+/20903">change 20903</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sim-auth/+/20903"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sim-auth </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1f972e308e14dbdbfc85892685682220a89f77fe </div>
<div style="display:none"> Gerrit-Change-Number: 20903 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: rousseau <ludovic.rousseau+osmocom@free.fr> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 16 Dec 2020 16:30:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>