Change in libosmocore[master]: gprs_ns2_vty: udp: fixup dialect changes

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/21747 )


Change subject: gprs_ns2_vty: udp: fixup dialect changes
......................................................................

gprs_ns2_vty: udp: fixup dialect changes

Only accept receiving ipaccess style messages when use-reset-block
is selected.
Also allow static ns alive NSVC when it's unselected.

Change-Id: Ia787528b1a6fac6bf1570c21643ef6cd8c209108
---
M src/gb/gprs_ns2_vty.c
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/21747/1

diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c
index 742f181..e33869b 100644
--- a/src/gb/gprs_ns2_vty.c
+++ b/src/gb/gprs_ns2_vty.c
@@ -901,7 +901,8 @@
 			/* TODO: could not bind on the specific address */
 			return -1;
 		}
-		bind->accept_ipaccess = true;
+
+		bind->accept_ipaccess = priv.vc_mode == NS2_VC_MODE_BLOCKRESET;
 	}
 
 	/* create vcs */
@@ -909,7 +910,10 @@
 		/* validate settings */
 		switch (vtyvc->ll) {
 		case GPRS_NS2_LL_UDP:
-			dialect = NS2_DIALECT_IPACCESS;
+			if (priv.vc_mode == NS2_VC_MODE_BLOCKRESET)
+				dialect = NS2_DIALECT_IPACCESS;
+			else
+				dialect = NS2_DIALECT_STATIC_ALIVE;
 			if (strlen(vtyvc->remote.ip) == 0) {
 				/* Invalid IP for VC */
 				continue;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21747
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia787528b1a6fac6bf1570c21643ef6cd8c209108
Gerrit-Change-Number: 21747
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201216/cd5dc91c/attachment.htm>