This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21721 ) Change subject: gprs_bssgp: add IE parser for RIM Routing Information ...................................................................... Patch Set 1: Code-Review-1 (7 comments) https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c File src/gb/gprs_bssgp.c: https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@340 PS1, Line 340: return 0; -EINVAL? https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@347 PS1, Line 347: return -1; return codes are not marching documentation. https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@350 PS1, Line 350: break; unneeded break. https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@357 PS1, Line 357: break; uneeded break. https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@359 PS1, Line 359: if (len < 7) You can probable merge both conditions in one if. https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@374 PS1, Line 374: break; unneeded break https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@379 PS1, Line 379: return 0; This cannot happen, you can remove it (or remove default above) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6f88a9aeeb50a612d32e9efd23040c9740bc4f11 Gerrit-Change-Number: 21721 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 15 Dec 2020 10:56:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201215/ca56a502/attachment.htm>