Change in libosmocore[master]: gprs_bssgp: add IE parser for RIM Routing Information

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21721 )

Change subject: gprs_bssgp: add IE parser for RIM Routing Information
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h@197 
PS1, Line 197: 		struct {
             : 				uint16_t mcc;
             : 				uint16_t mnc;
             : 				bool mnc_3_digits;
             : 				uint16_t tac;
             : 			} tai;
it might make sense to introduce a general/public 'struct' for this, like we have the gprs_ra_id.  With more LTE/GSM integration we might need that in more places.


https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h@204 
PS1, Line 204: uint8_t global_enb_id[8];
             : 			uint8_t global_enb_id_len;
likewise that might be wrappend in something like a public'struct osmo_g_enb_id'  - though I'm not sure it makes sense without parsing, so probably don't do it.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21721
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6f88a9aeeb50a612d32e9efd23040c9740bc4f11
Gerrit-Change-Number: 21721
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 15 Dec 2020 09:43:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201215/0ecf4997/attachment.htm>