<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h">File include/osmocom/gprs/gprs_bssgp.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h@197">Patch Set #1, Line 197:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">          struct {<br>                              uint16_t mcc;<br>                         uint16_t mnc;<br>                         bool mnc_3_digits;<br>                            uint16_t tac;<br>                 } tai;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">it might make sense to introduce a general/public 'struct' for this, like we have the gprs_ra_id.  With more LTE/GSM integration we might need that in more places.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/include/osmocom/gprs/gprs_bssgp.h@204">Patch Set #1, Line 204:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">uint8_t global_enb_id[8];<br>                        uint8_t global_enb_id_len;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">likewise that might be wrappend in something like a public'struct osmo_g_enb_id'  - though I'm not sure it makes sense without parsing, so probably don't do it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21721">change 21721</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21721"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f88a9aeeb50a612d32e9efd23040c9740bc4f11 </div>
<div style="display:none"> Gerrit-Change-Number: 21721 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 15 Dec 2020 09:43:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>