<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c">File src/gb/gprs_bssgp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@340">Patch Set #1, Line 340:</a> <code style="font-family:monospace,monospace">               return 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">-EINVAL?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@347">Patch Set #1, Line 347:</a> <code style="font-family:monospace,monospace">                  return -1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">return codes are not marching documentation.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@350">Patch Set #1, Line 350:</a> <code style="font-family:monospace,monospace">             break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unneeded break.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@357">Patch Set #1, Line 357:</a> <code style="font-family:monospace,monospace">              break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">uneeded break.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@359">Patch Set #1, Line 359:</a> <code style="font-family:monospace,monospace">               if (len < 7)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You can probable merge both conditions in one if.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@374">Patch Set #1, Line 374:</a> <code style="font-family:monospace,monospace">           break;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">unneeded break</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@379">Patch Set #1, Line 379:</a> <code style="font-family:monospace,monospace">       return 0;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This cannot happen, you can remove it (or remove default above)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/21721">change 21721</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/21721"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f88a9aeeb50a612d32e9efd23040c9740bc4f11 </div>
<div style="display:none"> Gerrit-Change-Number: 21721 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 15 Dec 2020 10:56:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>