This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21489 ) Change subject: BTS_Tests: as_l1_sacch(): fix Measurement Report padding ...................................................................... BTS_Tests: as_l1_sacch(): fix Measurement Report padding According to 3GPP TS 44.018, section 10.5.2.20, we should pad with zeroes. Change-Id: I912027fd53b12ff118254e941d6e5e696e1dd410 --- M bts/BTS_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 8a3b101..16e3d71 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -1867,8 +1867,8 @@ g_pars.l1_pars.ms_power_level, false, g_pars.l1_pars.ms_actual_ta); - /* TODO: we can use an extension of TTCN-3 for that, i.e. PADDING('2B'O) */ - var octetstring l2 := f_pad_oct(enc_LapdmFrameAB(valueof(lb)), 21, '2B'O); + /* According to 3GPP TS 44.018, section 10.5.2.20, we should pad with zeroes */ + var octetstring l2 := f_pad_oct(enc_LapdmFrameAB(valueof(lb)), 21, '00'O); log("Sending Measurement Report: ", l1h, l2); L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), l1h, l2)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I912027fd53b12ff118254e941d6e5e696e1dd410 Gerrit-Change-Number: 21489 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201213/d32cd482/attachment.htm>