<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21489">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests: as_l1_sacch(): fix Measurement Report padding<br><br>According to 3GPP TS 44.018, section 10.5.2.20, we should pad with zeroes.<br><br>Change-Id: I912027fd53b12ff118254e941d6e5e696e1dd410<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 8a3b101..16e3d71 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -1867,8 +1867,8 @@</span><br><span>                     g_pars.l1_pars.ms_power_level, false,</span><br><span>                        g_pars.l1_pars.ms_actual_ta);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-               /* TODO: we can use an extension of TTCN-3 for that, i.e. PADDING('2B'O) */</span><br><span style="color: hsl(0, 100%, 40%);">-             var octetstring l2 := f_pad_oct(enc_LapdmFrameAB(valueof(lb)), 21, '2B'O);</span><br><span style="color: hsl(120, 100%, 40%);">+            /* According to 3GPP TS 44.018, section 10.5.2.20, we should pad with zeroes */</span><br><span style="color: hsl(120, 100%, 40%);">+               var octetstring l2 := f_pad_oct(enc_LapdmFrameAB(valueof(lb)), 21, '00'O);</span><br><span> </span><br><span>               log("Sending Measurement Report: ", l1h, l2);</span><br><span>              L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), l1h, l2));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21489">change 21489</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21489"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I912027fd53b12ff118254e941d6e5e696e1dd410 </div>
<div style="display:none"> Gerrit-Change-Number: 21489 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>