Change in osmo-ttcn3-hacks[master]: BTS_Tests: make loop behavior in as_l1_sacch() configurable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Dec 3 12:12:39 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21490 )


Change subject: BTS_Tests: make loop behavior in as_l1_sacch() configurable
......................................................................

BTS_Tests: make loop behavior in as_l1_sacch() configurable

Unconditional 'repeat' statement renders additional statements
to be executed after the altstep's body useless:

  [] as_l1_sacch() { /* unreachable */ }

Let's fix this, so the following is possible:

  [] as_l1_sacch(loop := false) { /* additional statements */ }

Change-Id: I8c1f19f1543e53dd7564714a35fa94147fcfb8cf
---
M bts/BTS_Tests.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/21490/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 1be2201..94bb0d6 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1860,7 +1860,7 @@
 }
 
 /* handle incoming downlink SACCH and respond with uplink SACCH (meas res) */
-private altstep as_l1_sacch() runs on ConnHdlr {
+private altstep as_l1_sacch(boolean do_loop := true) runs on ConnHdlr {
 	var template (value) LapdmFrameAB lb;
 	var L1ctlDlMessage l1_dl;
 
@@ -1883,7 +1883,8 @@
 
 		log("Sending Measurement Report: ", l1h, l2);
 		L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), l1h, l2));
-		repeat;
+		if (do_loop)
+			{ repeat; }
 		}
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21490
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8c1f19f1543e53dd7564714a35fa94147fcfb8cf
Gerrit-Change-Number: 21490
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/97631226/attachment.htm>


More information about the gerrit-log mailing list