Change in pysim[master]: transport/__init.py__ add generic ATR hex read function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 26 10:54:30 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17934 )

Change subject: transport/__init.py__ add generic ATR hex read function
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py 
File pySim/transport/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py@93 
PS1, Line 93: 		p
> yes, my mistake here, this shoudln't have gone in the commit […]
Test suite: please see https://osmocom.org/issues/3376 and https://osmocom.org/issues/3890 - it is unfortuante that there is no wiki page describing it (there should be).  See the 'tests' and 'pysim-testdata' directories in the repository.  It is a physical setup with various card readres and the different SIM card types.  There's not really any other way to fully test a project like this.


https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py@108 
PS1, Line 108: 	d
> I am using it at the moment to debug the couple of SIMs I have, found a bit confusing the variables  […]
I think we shouldn't merge code unles we also have a user.  The user could be an immediate follow-up patch in the same series of patches.  But I haven't seen any of that so far.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17934
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id0e53ef50e32a8c3d2190581540b011eb89f8cc0
Gerrit-Change-Number: 17934
Gerrit-PatchSet: 1
Gerrit-Owner: guilly at gmail.com <guilly at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: guilly at gmail.com <guilly at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 26 Apr 2020 10:54:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: guilly at gmail.com <guilly at gmail.com>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200426/6ec1359a/attachment.htm>


More information about the gerrit-log mailing list