This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
guilly@gmail.com gerrit-no-reply at lists.osmocom.orgguilly at gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17934 ) Change subject: transport/__init.py__ add generic ATR hex read function ...................................................................... Patch Set 1: (2 comments) > Patch Set 1: Code-Review-1 > > (2 comments) https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py@93 PS1, Line 93: p > this change is not related to the ATR. It changes the output which breaks the test suite. […] yes, my mistake here, this shoudln't have gone in the commit side note, what's the test suite like? Is it pure software test, or do you have readers connected somewhere, testing against real cards? https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py@108 PS1, Line 108: d > so we add a new function but we don't use it anywhere? I am using it at the moment to debug the couple of SIMs I have, found a bit confusing the variables stored for card detection are in a format different to the internal. Trying to figure out if the existing cards match the ones I have, and playing with values, thought it would be nice to have. But if you don't want unnecessary code, then the commit can be abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id0e53ef50e32a8c3d2190581540b011eb89f8cc0 Gerrit-Change-Number: 17934 Gerrit-PatchSet: 1 Gerrit-Owner: guilly at gmail.com <guilly at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: guilly at gmail.com <guilly at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sun, 26 Apr 2020 09:06:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200426/7e49a71e/attachment.htm>