Change in pysim[master]: transport/__init.py__ add generic ATR hex read function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Apr 25 14:00:25 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17934 )

Change subject: transport/__init.py__ add generic ATR hex read function
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py 
File pySim/transport/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py@93 
PS1, Line 93: 		p
this change is not related to the ATR. It changes the output which breaks the test suite.  If you want to add APDU debugging, please make it off by default and require the  user to enable it explicitly by an argument or an environment variable.


https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py@108 
PS1, Line 108: 	d
so we add a new function but we don't use it anywhere?



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17934
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id0e53ef50e32a8c3d2190581540b011eb89f8cc0
Gerrit-Change-Number: 17934
Gerrit-PatchSet: 1
Gerrit-Owner: guilly at gmail.com <guilly at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 25 Apr 2020 14:00:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200425/7b23835e/attachment.htm>


More information about the gerrit-log mailing list