<p><a href="https://gerrit.osmocom.org/c/pysim/+/17934">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py">File pySim/transport/__init__.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py@93">Patch Set #1, Line 93:</a> <code style="font-family:monospace,monospace"> p</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">yes, my mistake here, this shoudln't have gone in the commit […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Test suite: please see https://osmocom.org/issues/3376 and https://osmocom.org/issues/3890 - it is unfortuante that there is no wiki page describing it (there should be). See the 'tests' and 'pysim-testdata' directories in the repository. It is a physical setup with various card readres and the different SIM card types. There's not really any other way to fully test a project like this.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/17934/1/pySim/transport/__init__.py@108">Patch Set #1, Line 108:</a> <code style="font-family:monospace,monospace"> d</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I am using it at the moment to debug the couple of SIMs I have, found a bit confusing the variables […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think we shouldn't merge code unles we also have a user. The user could be an immediate follow-up patch in the same series of patches. But I haven't seen any of that so far.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17934">change 17934</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17934"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id0e53ef50e32a8c3d2190581540b011eb89f8cc0 </div>
<div style="display:none"> Gerrit-Change-Number: 17934 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: guilly@gmail.com <guilly@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: guilly@gmail.com <guilly@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 26 Apr 2020 10:54:30 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: guilly@gmail.com <guilly@gmail.com> </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>