Change in osmo-pcu[master]: sba: fix possible memleak in SBAController::alloc()

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17877 )


Change subject: sba: fix possible memleak in SBAController::alloc()
......................................................................

sba: fix possible memleak in SBAController::alloc()

Change-Id: I417eda155cd5b1e46dd0b05db3f507abd79121d1
---
M src/sba.cpp
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/17877/1

diff --git a/src/sba.cpp b/src/sba.cpp
index 567babe..32735e8 100644
--- a/src/sba.cpp
+++ b/src/sba.cpp
@@ -55,13 +55,13 @@
 	int8_t trx, ts;
 	uint32_t fn;
 
+	if (!gsm48_ta_is_valid(ta))
+		return -EINVAL;
+
 	sba = talloc_zero(tall_pcu_ctx, struct gprs_rlcmac_sba);
 	if (!sba)
 		return -ENOMEM;
 
-	if (!gsm48_ta_is_valid(ta))
-		return -EINVAL;
-
 	for (trx = 0; trx < 8; trx++) {
 		for (ts = 7; ts >= 0; ts--) {
 			pdch = &m_bts.bts_data()->trx[trx].pdch[ts];

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17877
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I417eda155cd5b1e46dd0b05db3f507abd79121d1
Gerrit-Change-Number: 17877
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200420/a5d1788b/attachment.htm>