<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17877">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sba: fix possible memleak in SBAController::alloc()<br><br>Change-Id: I417eda155cd5b1e46dd0b05db3f507abd79121d1<br>---<br>M src/sba.cpp<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/77/17877/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sba.cpp b/src/sba.cpp</span><br><span>index 567babe..32735e8 100644</span><br><span>--- a/src/sba.cpp</span><br><span>+++ b/src/sba.cpp</span><br><span>@@ -55,13 +55,13 @@</span><br><span>   int8_t trx, ts;</span><br><span>      uint32_t fn;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      if (!gsm48_ta_is_valid(ta))</span><br><span style="color: hsl(120, 100%, 40%);">+           return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    sba = talloc_zero(tall_pcu_ctx, struct gprs_rlcmac_sba);</span><br><span>     if (!sba)</span><br><span>            return -ENOMEM;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     if (!gsm48_ta_is_valid(ta))</span><br><span style="color: hsl(0, 100%, 40%);">-             return -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      for (trx = 0; trx < 8; trx++) {</span><br><span>           for (ts = 7; ts >= 0; ts--) {</span><br><span>                     pdch = &m_bts.bts_data()->trx[trx].pdch[ts];</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17877">change 17877</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17877"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I417eda155cd5b1e46dd0b05db3f507abd79121d1 </div>
<div style="display:none"> Gerrit-Change-Number: 17877 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>