This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17876 ) Change subject: SMS-over-GSUP: notify sender if no transaction found ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/17876/1/src/libmsc/gsm_04_11_gsup.c File src/libmsc/gsm_04_11_gsup.c: https://gerrit.osmocom.org/c/osmo-msc/+/17876/1/src/libmsc/gsm_04_11_gsup.c@164 PS1, Line 164: GMM_CAUSE_NO_PDP_ACTIVATED > are you sure a PDP context related error is the right one to return here? Well, we're using GMM specific cause values (see enum gsm48_gmm_cause) for something that has noting to do with GPRS. This cause value is like -ENODEV in the context of SMS transactions. I could not find anything better. But wait, I just realized that we can use OSMO_GSUP_SM_RP_CAUSE_IE and a more concrete cause instead! -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4f564610fadbfdbbc33de267786534a5405319f6 Gerrit-Change-Number: 17876 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sat, 25 Apr 2020 14:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200425/485e3640/attachment.htm>