This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 ) Change subject: Implement GMM State using osmocom FSM ...................................................................... Patch Set 1: (2 comments) Same comments apply to both 'mm_state_gb_fsm' and 'mm_state_iu_fsm'. https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_gmm_state_fsm.h File include/osmocom/sgsn/gprs_gmm_state_fsm.h: https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_gmm_state_fsm.h@6 PS1, Line 6: gmm_state_fsm_states > I'm simply following convention of naming _states and _events the fields of an osmocom FSM. This is fine, I have nothing against '_states' and '_events' postfixes. > It happens to be be by casuality that the machine definition is named "GMM state" Right now we have 'gmm_state' field in the 'sgsn_mm_ctx' structure. The purpose of this field is to store the current state, so it's logical to call it that way. You're introducing the FSM, so it doesn't make sense to follow the old naming. https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_sgsn.h File include/osmocom/sgsn/gprs_sgsn.h: https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_sgsn.h@122 PS1, Line 122: gmm_state_fsm In the other comment I mentioned this field. Let's call it 'gmm_fsm'. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Idecb43c10d66224d4f9ba9320825040ce6cf9a07 Gerrit-Change-Number: 15385 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Tue, 03 Sep 2019 11:49:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190903/7182f81b/attachment.htm>