<p style="white-space: pre-wrap; word-wrap: break-word;">Same comments apply to both 'mm_state_gb_fsm' and 'mm_state_iu_fsm'.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15385">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_gmm_state_fsm.h">File include/osmocom/sgsn/gprs_gmm_state_fsm.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_gmm_state_fsm.h@6">Patch Set #1, Line 6:</a> <code style="font-family:monospace,monospace">gmm_state_fsm_states</code></p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">I'm simply following convention of naming _states and _events the fields of an osmocom FSM.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">This is fine, I have nothing against '_states' and '_events' postfixes.</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">It happens to be be by casuality that the machine definition is named "GMM state"</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Right now we have 'gmm_state' field in the 'sgsn_mm_ctx' structure. The purpose of this field is to store the current state, so it's logical to call it that way. You're introducing the FSM, so it doesn't make sense to follow the old naming.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_sgsn.h">File include/osmocom/sgsn/gprs_sgsn.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_sgsn.h@122">Patch Set #1, Line 122:</a> <code style="font-family:monospace,monospace">gmm_state_fsm</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In the other comment I mentioned this field. Let's call it 'gmm_fsm'.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15385">change 15385</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15385"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idecb43c10d66224d4f9ba9320825040ce6cf9a07 </div>
<div style="display:none"> Gerrit-Change-Number: 15385 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 03 Sep 2019 11:49:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>