Change in ...osmo-sgsn[master]: Implement GMM State using osmocom FSM

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Sep 2 16:06:33 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 )

Change subject: Implement GMM State using osmocom FSM
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_gmm_state_fsm.h 
File include/osmocom/sgsn/gprs_gmm_state_fsm.h:

https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_gmm_state_fsm.h@6 
PS1, Line 6: gmm_state_fsm_states
> I find this naming confusing: 'state FSM states'? Maybe it's time to drop this 'state' prefix since  […]
I'm simply following convention of naming _states and _events the fields of an osmocom FSM. It happens to be be by casuality that the machine definition is named "GMM state", so in this case it's expected to end up having this kind of naming.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15385
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Idecb43c10d66224d4f9ba9320825040ce6cf9a07
Gerrit-Change-Number: 15385
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 02 Sep 2019 16:06:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190902/3db9e87f/attachment.htm>


More information about the gerrit-log mailing list