This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15019 )
Change subject: Transmit Bearer Caps to MNCC with SETUP_REQ
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
this is interesting, because it would finally add codec information to the MNCC socket.
Given the period of inactivity on this patch, I guess you know this already, but for completeness' sake:
This is only implementing two codec types, and it is not this trivial to derive the Speech Version just from the payload type number. Doing this right would need to correlate the SDP codec names instead. (the SDP in SIP could assign any payload type numbers to any codec)
Instead, we have another approach for this, i.e. adding complete SDP to the MNCC socket,
https://gerrit.osmocom.org/q/topic:%22codecs%22+(project:%22osmo-msc%22%20OR%20project:%22osmo-sip-connector%22)
-- those patches are in review and I'm actively working on getting them merged.
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15019/1/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15019/1/src/mncc.c@824
PS1, Line 824: struct gsm_mncc_bearer_cap bearer_cap
> Right, I started thinking to set a default bearer cap in a temporary variable that would apply for a […]
FYI, the syntax would have been
mncc.bearer_cap = (struct gsm_mncc_bearer_cap){ .transfer = ..., .mode = ... };
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15019/1/src/mncc.c@829
PS1, Line 829: .speech_ver = { GSM48_BCAP_SV_FR,
the most impact is made by these speech_ver entries.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15019
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I55cdc4b7c52730d7e998a1d692c7552fd07403ee
Gerrit-Change-Number: 15019
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 26 Nov 2019 03:40:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191126/6d177aa1/attachment.htm>