Change in osmo-bts[master]: common/vty.c: fix: properly assert() the result of get_string_value()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Nov 26 10:15:21 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16223 )


Change subject: common/vty.c: fix: properly assert() the result of get_string_value()
......................................................................

common/vty.c: fix: properly assert() the result of get_string_value()

Change-Id: I6ecd46371e601ad0fb629f9756b36c9c4758a958
Fixes: CID#205067, CID#205068
---
M src/common/vty.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/23/16223/1

diff --git a/src/common/vty.c b/src/common/vty.c
index 2558ba8..8b947a7 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -1613,7 +1613,7 @@
 	struct log_target *tgt = osmo_log_vty2tgt(vty);
 	uint16_t **sapi_mask;
 
-	OSMO_ASSERT(sapi < 0);
+	OSMO_ASSERT(sapi >= 0);
 	if (!tgt)
 		return CMD_WARNING;
 
@@ -1635,7 +1635,7 @@
 	struct log_target *tgt = osmo_log_vty2tgt(vty);
 	uint16_t *sapi_mask;
 
-	OSMO_ASSERT(sapi < 0);
+	OSMO_ASSERT(sapi >= 0);
 	if (!tgt)
 		return CMD_WARNING;
 	if (!tgt->filter_data[LOG_FLT_L1_SAPI])

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16223
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd46371e601ad0fb629f9756b36c9c4758a958
Gerrit-Change-Number: 16223
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191126/d23c34d1/attachment.htm>


More information about the gerrit-log mailing list