Change in libosmocore[master]: gsup: Introduce OSMO_GSUP_NUM_VECTORS_REQ_IE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Nov 26 03:23:31 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15321 )

Change subject: gsup: Introduce OSMO_GSUP_NUM_VECTORS_REQ_IE
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/15321/4//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/15321/4//COMMIT_MSG@9 
PS4, Line 9: This is a bit of a hack, as we want to maintain binary compatibility
maintain binary compatibility: you mean as in the struct osmo_gsup_message size? We did add more elements to the struct on various occasions before this. Is this case different?

We should maybe add a "more" bool indicator to the end to allow future extensions, like http://git.osmocom.org/libosmocore/tree/include/osmocom/gsm/gsm0808.h#n143 ?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15321
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iaecc47280f8ce54f3e3a888c1cfc160735483d0f
Gerrit-Change-Number: 15321
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Nov 2019 03:23:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191126/264e74e6/attachment.htm>


More information about the gerrit-log mailing list