This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12907 ) Change subject: Don't install pcuif_proto.h header ...................................................................... Patch Set 1: Code-Review+1 > I don't like the idea of having separate copies of the protocol > definition. This is similar to the situation with MNCC - one needs > to keep all existing copies updated. Why not to move it to > libosmocore? In general, it has proven a very bad idea to move "shared" header files between projects to libosmocore, particularly if the related interfaces are still subject to being changed. This means that a lot of chagnes to the header file will introduce all kinds of forward/backward API compatibility problems. We've had "gsm_data_shared.h" which was shared between openbsc + osmo-bts for a long time, and it was a nightmare as you always needed to have two very closely-matching bodies of the source repositories in order to build osmo-bts at all. I prefer to have each project build by its own, with *very* little external depedencies. incompatible versions of a given protocol should be detecetd by having version numbers inside the protocol itself. -- To view, visit https://gerrit.osmocom.org/12907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a87395d4ab7212fe2fc055dae0a737e10d20c69 Gerrit-Change-Number: 12907 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 14 Feb 2019 21:41:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190214/d2ae754e/attachment.htm>