Change in osmo-pcu[master]: Don't install pcuif_proto.h header

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Feb 14 19:15:00 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12907 )

Change subject: Don't install pcuif_proto.h header
......................................................................


Patch Set 1:

> > What's the problem with installing it? How does this patch
 > simplify installation?
 > 
 > It simplifies installation by not installing useless files. The
 > potential problem is that we install pkg-config file for something
 > which is used only locally. That's plain wrong.

I think it's a good idea to install it since (maybe not osmo-bts now) any application that wants to talk this interface needs to get the header definitions from somewhere to compile its code. I agree with Vadim that having a copy is probably not the best approach.

Are osmo-bts and osmo-pcu both installing this file at exactly the same location? If that's the case, then let's install it from one repo, most probably the one acting as a server on the unix socket.


-- 
To view, visit https://gerrit.osmocom.org/12907
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a87395d4ab7212fe2fc055dae0a737e10d20c69
Gerrit-Change-Number: 12907
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 19:15:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190214/dbc232c4/attachment.htm>


More information about the gerrit-log mailing list