This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/12907 ) Change subject: Don't install pcuif_proto.h header ...................................................................... Patch Set 1: > I think it's a good idea to install it since (maybe not osmo-bts now) any application that wants to talk this interface Which application do you have in mind exactly? It's a very specific niche protocol. In more than 10 years it's been used by osmo-bts and osmo-bsc only and I really doubt this is going to be any different in next 10 years. > Are osmo-bts and osmo-pcu both installing this file at exactly the same location? OsmoBTS does not install it (local copy is used). OsmoBSC does not install it (local copy is used). OsmoPCU uses local copy as well but for legacy reasons it also installs it globally. This patch proposes to change that and make OsmoPCU behave like OsmoBTS and OsmoBSC. In general I think it only make sense to have single copy of this file as long as all related functions are in the same repo: serialization, deserialization, tests, data structures etc. But that would be much more intrusive change. -- To view, visit https://gerrit.osmocom.org/12907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a87395d4ab7212fe2fc055dae0a737e10d20c69 Gerrit-Change-Number: 12907 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 15 Feb 2019 15:15:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190215/6cfe7ab7/attachment.htm>