[PATCH] openbsc[master]: gsm_bts: add version and variant details

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Mar 23 11:51:56 UTC 2017


Hello Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/2161

to look at the new patch set (#2).

gsm_bts: add version and variant details

* add version string to gsm_bts
* add PCU version string to gsm_bts_trx
* add variant enum to gsm_bts_model using eunm with variants for each
  hw vendor of OsmoBTS

This will come in handy when logging details regarding particular BTS
reported via OML, see:

Related: OS#1614

Change-Id: I6710d53115f34634a7b70969cc05fd5c72ff8ab2
---
M openbsc/include/openbsc/gsm_data_shared.h
1 file changed, 17 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/61/2161/2

diff --git a/openbsc/include/openbsc/gsm_data_shared.h b/openbsc/include/openbsc/gsm_data_shared.h
index 06fa8dd..d712253 100644
--- a/openbsc/include/openbsc/gsm_data_shared.h
+++ b/openbsc/include/openbsc/gsm_data_shared.h
@@ -64,6 +64,8 @@
 #define HARDCODED_BTS1_TS	6
 #define HARDCODED_BTS2_TS	11
 
+#define MAX_VERSION_LENGTH 64
+
 enum gsm_hooks {
 	GSM_HOOK_NM_SWLOAD,
 	GSM_HOOK_RR_PAGING,
@@ -433,6 +435,9 @@
 	/* Some BTS (specifically Ericsson RBS) have a per-TRX OML Link */
 	struct e1inp_sign_link *oml_link;
 
+	/* Connected PCU version (if any) */
+	char pcu_version[MAX_VERSION_LENGTH];
+
 	struct gsm_abis_mo mo;
 	struct tlv_parsed nm_attr;
 	struct {
@@ -493,12 +498,22 @@
 	_NUM_GSM_BTS_TYPE
 };
 
+enum gsm_bts_model_variant {
+	BTS_UNKNOWN,
+	BTS_LITECELL15,
+	BTS_OCTPHY,
+	BTS_SYSMO,
+	BTS_TRX,
+	_NUM_BTS_VARIANT
+};
+
 struct vty;
 
 struct gsm_bts_model {
 	struct llist_head list;
 
 	enum gsm_bts_type type;
+	enum gsm_bts_model_variant variant;
 	const char *name;
 
 	bool started;
@@ -653,6 +668,8 @@
 	enum gsm_bts_type type;
 	struct gsm_bts_model *model;
 	enum gsm_band band;
+	char version[MAX_VERSION_LENGTH];
+
 	/* maximum Tx power that the MS is permitted to use in this cell */
 	int ms_max_power;
 

-- 
To view, visit https://gerrit.osmocom.org/2161
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6710d53115f34634a7b70969cc05fd5c72ff8ab2
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list