This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 2: Code-Review-1
(2 comments)
plz clarify some details...
https://gerrit.osmocom.org/#/c/2161/2/openbsc/include/openbsc/gsm_data_shared.h
File openbsc/include/openbsc/gsm_data_shared.h:
Line 501: enum gsm_bts_model_variant {
this qestion is still open:
It looks to me like this is semantically the same as enum gsm_bts_type just above?
If it has to be a separate enum, please clarify with a code comment why that is so.
Line 671: char version[MAX_VERSION_LENGTH];
I wonder why the variant is in gsm_bts_model and the version is in gsm_bts. Aren't they the same kind of information and should be kept together?
Isn't gsm_bts_model "just" an internal API collection? will we have separate gsm_bts_model APIs based on the variant? So far that's not the case, right?
--
To view, visit https://gerrit.osmocom.org/2161
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6710d53115f34634a7b70969cc05fd5c72ff8ab2
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes