openbsc[master]: gsm_bts: add version details

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Mar 23 11:40:58 UTC 2017


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/2161/1//COMMIT_MSG
Commit Message:

Line 7: gsm_bts: add version details
'and variant'


Line 12:   hw vendor of OsmoBTS
could you explain to the uninformed reader why this is useful and who will use it? thx!


https://gerrit.osmocom.org/#/c/2161/1/openbsc/include/openbsc/gsm_data_shared.h
File openbsc/include/openbsc/gsm_data_shared.h:

Line 502: 	BTS_UNKNOWN,
It looks to me like this is semantically the same as enum gsm_bts_type just above?

Rather not have a mix of BTS_ / OSMO_BTS_ prefixes.
The OSMO_ prefix is reserved basically for libosmocore (we agreed on it a few months back).


-- 
To view, visit https://gerrit.osmocom.org/2161
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6710d53115f34634a7b70969cc05fd5c72ff8ab2
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list