This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/1062/1/include/osmocom/iuh/hnbgw.h File include/osmocom/iuh/hnbgw.h: Line 161: const char *hnbgw_get_iucs_remote_ip(struct hnb_gw *gw); > I really don't like the getter functions for each and every config item we I agree that it is bloaty. The idea why they came up is that the default is used automatically when no value is set, and that we can distinguish between whether the user set a value or not. Why? Because in the VTY, upon config 'write', we want to ouput the exact same config that was read in from the config file earlier. So if the user had no config, the code outputs nothing; if the user had a value set, the code writes that value, even if the user set the default value "by coincidence". Admittedly, this idea got lost in this patch, because it also omits the vty output when the value is explicitly set to the default. For my argument to be valid, I would have to write out the config when it is set, even if it is the default value. So I presume you would like me to drop all that? How should the VTY behave though, omit output when it finds that the default is set? Always write whatever is found = the leanest code? -- To view, visit https://gerrit.osmocom.org/1062 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c28977011009df4e1fa472290bbbc359e406971 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes