osmo-iuh[master]: hnbgw: parameterize IuCS and IuPS ips and ports: add vty cmds

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Oct 18 17:30:07 UTC 2016


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/1062/1/include/osmocom/iuh/hnbgw.h
File include/osmocom/iuh/hnbgw.h:

Line 161: const char *hnbgw_get_iucs_remote_ip(struct hnb_gw *gw);
I really don't like the getter functions for each and every config item we have.  This adds no value, as far as I can tell. Rather than adding more, we should work on removing those that already exist.


-- 
To view, visit https://gerrit.osmocom.org/1062
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c28977011009df4e1fa472290bbbc359e406971
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list