osmo-iuh[master]: hnbgw: parameterize IuCS and IuPS ips and ports: add vty cmds

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Oct 27 10:26:28 UTC 2016


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/1062/1/include/osmocom/iuh/hnbgw.h
File include/osmocom/iuh/hnbgw.h:

Line 161: const char *hnbgw_get_iucs_remote_ip(struct hnb_gw *gw);
> I agree that it is bloaty. The idea why they came up is that the default is
I'm not sure we ever had a requirement that 'config write' should write an identical file than we read.  It should not change the behavior of the program, but whether or not a default is explicit or implicit shouldn't make the difference.

the policy so far was to write paramters only if they differ from the compile-time default.  Whether or not that is a good policy might be debatable, but I don't think we should start to differ from that behavior in some of the code while keeping the other code-as is.

So yes, I would prefer if all of those get/set functions go away. Thanks.

btw: My long-term wish is to move all of the VTY code out into a separate 'configuration management + cli daemon' which then has a MIB API which is used by the programs like the NITB to get the parameters asneeded.  So let's not spend more time adding more complexity to what we have so far.


-- 
To view, visit https://gerrit.osmocom.org/1062
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c28977011009df4e1fa472290bbbc359e406971
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list