Re: PATCH: bitwise msb-first table-based 16bit CRC calculation

Hi, As I said in IRC, I would put it as 'template' in libosmocore, replacing the 16 with like @N@ Then in the make file, use a couple of sed to generate the .c / .h for the 8,16,32,64 bits versions. This way it could be used for GSM as wel where a wide variety of CRC polynoms are used (from 4 bits up to 40 bits ...) I think it should compile just fine for the target, nothing special there and if we don't use it it won't be included. It's mostly code than uses libc io stuff that's tricky. Standard tables could indeed be included in the code by default for well known CRC, but the ability to compute/use tables dynamically should stay. A small utility to generate the .c code for such tables should be added then. So you could have stuff like: crc_tbl_ccit.c: crc_tbl_gen crc_tbl_gen 0x????? > crc_tbl_ccit.c Other comments: - name it crc16.c (the function name osmo_xxx is fine, but for the file name, none of the others have osmo_ prefix ... we're in osmocore) - Oh, I just noticed there is a crc16.c already ... that's just confusing, need better naming than that. - If we indeed do a lot of crc (8/16/32/64) with some prebuilt table, maybe a directory/separate lib ? (like the vty/codec stuff) just a tought. That would also split the crc used for pbit/ubits from the 'traditional' crc16. - Unaligned bit start in pbits. - For the ubits case, the function makes it look like you need the whole table ... when in fact you just need the poly. Maybe take the poly as argument and add a macro crc_tbl2poly that takes the element[1] ? This way, if you only use ubits, you can just have the poly without tables at all ... Cheers, Sylvain