openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-821-g3fb6fbd

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 18d3450120796026837803177a9b39862effdcc3 (commit) discards ac4c60a3df10e436f21a522a0a10e285f8a7b5e1 (commit) discards 8243b2643ec61ea471ff5f57f6c625575d6a8c95 (commit) discards c0d0293319faf0e5d254c6150b18780b462a1e17 (commit) discards d955555e7dccee0eeb8aa4b5300ec0d44f182a9e (commit) discards 7afcad12a5011e121a8c9727efe2954fe9b48033 (commit) discards 37a9de32ab6ead088fad421de0ee82a676fb3f20 (commit) discards cecedbf4478d65d0bf76f3ec922c00ed60f551b4 (commit) discards bb7048fbf731b768f4a982854145b56c616ed0ad (commit) discards e5b78fb52e06d9008ce09f8429bb49c7df9d2401 (commit) discards be5f5cf232e80926b62cd3d42d75a50aa60dbd19 (commit) discards 58affb6cf017e869bd89c6fa04dc4bf539a999d3 (commit) discards d7ee04647aa9d5ad69d86a6bb60e1543e2a1f1a1 (commit) discards 3ef64da79208515ccdd1b707a3e629581537bfa0 (commit) discards ced7abab7695a1c3019933b8dfc838693505d14e (commit) discards ed47c392a848a59f77f973aa578179d9565bf36c (commit) discards 64cae3b725c93d98aff6bc244190df309ea44150 (commit) discards c8b72181fef62e4be671fdba1e075d402cc0841e (commit) discards 4feb7f8f13d64aea5e4fbf7d8f1b104cd3fd4ca4 (commit) discards 57a0ab1b78cce5bc61b738b0066e663362973346 (commit) discards f6f00e526428811286b2cb60779f78a629efc396 (commit) discards 0666b6d027a5674e004be679100510481eb5ce33 (commit) discards 6398f890fdee5a5b8d5c759c62b5d355489a55ad (commit) discards 9dcfad0aaf7dde706b2731ca02dbe435fd23205a (commit) discards 3454b19788cb40e94d8dcc83c79a11190a48479a (commit) discards f90a0222471e81f7795012325ab6975450c78ef9 (commit) discards 68c53a87f6a142b2c2d24b06a2bc4c71802f1751 (commit) discards 0da1846420d7d1e049e30ab04bc37cce7a96a204 (commit) discards 10248d02767e4110c654548b8154b7d3d6806e2e (commit) via 3fb6fbddfd6c7c524d9718953e11d1253c176c03 (commit) via 615c0089f0dd6c9794a93ff30136f4d5680b3527 (commit) via 69dbfccd9617d890ab47f8f3be5f12268ef97fe4 (commit) via 477687d28b2fd4d0c802980d9520a0dac9f48b1c (commit) via fc1a40a908eed3783fd1ef952bff4439e92c011e (commit) via 52cbc48dc3b34c8cbf0fbe4c3dec80fc115d6103 (commit) via 0898453bcc9a4d29c1b7a350af3bb2c657c13887 (commit) via d0d19575645fbb55675a920dddf9e0b908e344a6 (commit) via dc705156990875cce47e91be02d6e11eb42ec297 (commit) via 7ba0f5153d236baafae9c4fa35bd19b9dae8fa79 (commit) via 877eaefa8b2f13758103eb77aeaa57db4bb58ef4 (commit) via 20fba7e41677012efaf84b869f270c364b44067e (commit) via 0331b92277f541f64b2928a7996e23f55ef86e1e (commit) via b633cac56859a73cfe955aaca42e4624064c7a24 (commit) via 8c53be038f73ef0ec41990cca44e3acf51c608e2 (commit) via db0f3dc595fd081cb26df84b0a534614cf35e018 (commit) via a458d7ef7835891237b2c271d9365e59691cbb0a (commit) via 9b731ee8145248104016a66a5617706321d112a1 (commit) via 82c9c6a70704677fd691e6a2c5e865d490a944bc (commit) via 3e2ade7f718ceaaa7bfdc70da0c666c2a4096d6d (commit) via db7e1e46f258f8697a952d0cec52601f8fb9d0e1 (commit) via fd40f97341add367623ce9133ee47df62956db94 (commit) via 91ba21fc94d0e2bcb1b2416d111e893232bc0c1b (commit) via 20d9b880e538c8728e825b4bb74ededb1a67ee20 (commit) via 7dba11fe32615fb5e49fae0a3bbd787ce4abc9b7 (commit) via 3ea2260d00b42e6e5172d0db27aac30ca28d6640 (commit) via 4b59d24f4f97f75f7f62ef31112870892d08b8f8 (commit) via 697a534ed64e76de3cfb8b558e40d081f70b31ff (commit) via dcfd456640b6e15f15c94f175eb145220b96ee1a (commit) via c93919655753591bc883165f03f204a8773c4f64 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (18d3450120796026837803177a9b39862effdcc3) \ N -- N -- N (3fb6fbddfd6c7c524d9718953e11d1253c176c03) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=3fb6fbddfd6c7c524d9718953e11d125… commit 3fb6fbddfd6c7c524d9718953e11d1253c176c03 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Tue Dec 23 14:24:16 2014 +0100 sgsn: Handle GSUP errors (WIP) Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=615c0089f0dd6c9794a93ff30136f4d5… commit 615c0089f0dd6c9794a93ff30136f4d5680b3527 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=69dbfccd9617d890ab47f8f3be5f1226… commit 69dbfccd9617d890ab47f8f3be5f12268ef97fe4 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=477687d28b2fd4d0c802980d9520a0da… commit 477687d28b2fd4d0c802980d9520a0dac9f48b1c Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fc1a40a908eed3783fd1ef952bff4439… commit fc1a40a908eed3783fd1ef952bff4439e92c011e Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=52cbc48dc3b34c8cbf0fbe4c3dec80fc… commit 52cbc48dc3b34c8cbf0fbe4c3dec80fc115d6103 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:19:46 2014 +0100 sgsn: Show GSUP client info on 'show sgsn' This commit adds a line to the output of 'show sgsn' if the GSUP client has been initialized: - Remote authorization: [not] connected to HOST:PORT via GSUP Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0898453bcc9a4d29c1b7a350af3bb2c6… commit 0898453bcc9a4d29c1b7a350af3bb2c657c13887 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:18:54 2014 +0100 sgsn: Send PING and eventually reconnect Currently, the reconnect mechanism relies on gsup_client_updown_cb which in turn gets called based on the OS' view of connection state. This patch adds a timer based PING mechanism that regularly sends PING messages and forces a reconnect if a PONG message won't be received until the next PING message is scheduled. The current ping interval is 20s. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d0d19575645fbb55675a920dddf9e0b9… commit d0d19575645fbb55675a920dddf9e0b908e344a6 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:15:55 2014 +0100 sgsn: Handle incoming IPA CCM message in gsup_client_read_cb Currently the IPA CCM messages are not handled by the GSUP client. This means, that the client doesn't answer to PING and ID_GET and logs notices when receiving PONG or ID_ACK. At least the PING functionality (remotely originated PING) shall be supported. This patch extends gsup_client_read_cb by a call to ipaccess_bts_handle_ccm. Only when the return code is 0, the message is processed further and checked for an OSMO/GSUP message. ID_GET messages are answered by a dummy description, where only the unit_name is set to 'SGSN'. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=dc705156990875cce47e91be02d6e11e… commit dc705156990875cce47e91be02d6e11eb42ec297 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:00:56 2014 +0100 sgsn: Handle return code of ipa_client_conn_open correctly The ipa_client_conn_open function does not distinguish between a connection being already established or waiting for establishment. In either case, the application gets informed about the connection state via the updown_cb. The 'up' parameter is only set, if poll/select consider the socket as writable. This patch handles both cases equally and fully relies on the updown_cb to adjust the gsupc obejct state. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7ba0f5153d236baafae9c4fa35bd19b9… commit 7ba0f5153d236baafae9c4fa35bd19b9dae8fa79 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 18:50:05 2014 +0100 sgsn: Avoid sending stale GSUP requests after reconnect Currently, messages are added to the tx queue even if the connection is down for some reason and all of these messages are eventually sent after a re-connect. The MS has probably sent several Attach Requests while the connection was down and will continue doing so. Therefore these stored messages could be dropped. This patch clears the queue before re-connecting and also extends gprs_gsup_client_send to return immediately, when the connection is not established instead of calling ipa_client_conn_send. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=877eaefa8b2f13758103eb77aeaa57db… commit 877eaefa8b2f13758103eb77aeaa57db4bb58ef4 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Dec 18 15:00:29 2014 +0100 sgsn: Add automatic re-connect if the GSUP connection is down Currently the GSUP connection to a server is not restarted if the connection cannot be established or is terminated during operation. This commit adds a timer based connection mechanism, basically consisting of a timer callback that calls gsup_client_connect. The timer is eventually triggered (up == 0) or cleared (up != 0) by gsup_client_updown_cb. It adds calls to osmo_timer_del() to gsup_client_connect and gprs_gsup_client_destroy. The latter is now called instead of talloc_free in gprs_gsup_client_create on error to be on the safe side. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=20fba7e41677012efaf84b869f270c36… commit 20fba7e41677012efaf84b869f270c364b44067e Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 18:30:41 2014 +0100 sgsn/test: Extend tests to simulate lost GSUP requests This patch extends test_gmm_attach to optionally resend Attach Requests until the SGSN responds to it instead of calling OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth test optionally uses this feature. It is called once in either mode. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0331b92277f541f64b2928a7996e23f5… commit 0331b92277f541f64b2928a7996e23f55ef86e1e Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 18:26:09 2014 +0100 sgsn/test: Add GMM test for a GSUP based attach procedure This test calls test_gmm_attach() where the mocked subscriber functions insert GSUP messages instead of manipulating the subscriber structure directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b633cac56859a73cfe955aaca42e4624… commit b633cac56859a73cfe955aaca42e4624064c7a24 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 18:19:50 2014 +0100 sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message Currently, several lines of boiler plate are needed around a call to gprs_subscr_rx_gsup_message. This patch puts all of this (including the call to gprs_subscr_rx_gsup_message) into a separate function. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8c53be038f73ef0ec41990cca44e3acf… commit 8c53be038f73ef0ec41990cca44e3acf51c608e2 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 18:08:48 2014 +0100 sgsn: Add global require_update_location flag This flag is used to determine, whether the Update Location procedure shall be invoked. This is currently only set, when the 'remote' authorization policy is set. When the flag is set, sgsn_auth_update will not never be called directly by sgsn_auth_request, if an Attach Request procedure is pending, even if the remote connection fails for some reason. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=db0f3dc595fd081cb26df84b0a534614… commit db0f3dc595fd081cb26df84b0a534614cf35e018 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Wed Dec 17 13:20:08 2014 +0100 sgsn: Replace subscr.authenticate by global require_authentication flag Currently the flag 'authenticate' is managed per subscriber. This patch replaces that flag by a global cfg.require_authentication flag that enables/disables the use of the Auth & Ciph procedure for every subscriber. The flag is set by the VTY, if and only if the authorization policy is 'remote'. The VTY command - update-subscriber imsi IMSI insert authenticate <0-1> is removed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a458d7ef7835891237b2c271d9365e59… commit a458d7ef7835891237b2c271d9365e59691cbb0a Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Dec 18 12:46:47 2014 +0100 sgsn: Integrate the GSUP client into the SGSN This commit adds GSUP client configuration (via VTY), connection set up, and real message sending. The following configuration commands are added: - gsup remote-ip A.B.C.D set server IP address - gsup remote-port PORT set server TCP port Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9b731ee8145248104016a66a56177063… commit 9b731ee8145248104016a66a5617706321d112a1 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Dec 18 12:28:21 2014 +0100 sgsn: Add GSUP client This commit adds the client code to get subscriber information from a remote server. It provides an IPA over TCP connection to transmit and receive GSUP messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=82c9c6a70704677fd691e6a2c5e865d4… commit 82c9c6a70704677fd691e6a2c5e865d490a944bc Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Mon Dec 15 10:16:02 2014 +0100 sgsn/doc: Add IPA default parameters This commit adds the default protocol identifiers that should be used for GSUP by the IPA protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3e2ade7f718ceaaa7bfdc70da0c666c2… commit 3e2ade7f718ceaaa7bfdc70da0c666c2a4096d6d Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 12 15:01:37 2014 +0100 gprs: Add subscriber functions to create/handle GSUP messages This patch extends gprs_subscr_query_auth_info and gprs_subscr_location_update to create GSUP messages with the help of a static gprs_subscr_tx_gsup_message function. A corresponding gprs_subscr_rx_gsup_message is added which takes a messages, gets the subscr, and updates it accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=db7e1e46f258f8697a952d0cec52601f… commit db7e1e46f258f8697a952d0cec52601f8fb9d0e1 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Dec 11 16:54:14 2014 +0100 gprs: Add encoder/decoder for the Subscriber Update Protocol This patch adds functions to encode and decode GSUP messages. This does not include the layer 1 framing (IPA). The messages so far supported are: send_auth_info_*, update_location_*, location_cancellation_*. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fd40f97341add367623ce9133ee47df6… commit fd40f97341add367623ce9133ee47df62956db94 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Dec 11 15:14:14 2014 +0100 sgsn/doc: Add protocol specification for remote subscriber update This is the first version of the specification for the GPRS Subscriber Update Protocol. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=91ba21fc94d0e2bcb1b2416d111e8932… commit 91ba21fc94d0e2bcb1b2416d111e893232bc0c1b Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Nov 28 14:55:25 2014 +0100 sgsn: Add a subscriber based authentication phase This implements the MAP way of subscriber validation when the MS tries to perform an Attach Request: 1. perform authentication (optionally invoke the sendAuthInfo procedure), starts the Auth & Ciph procedure 2. perform update location 3. insert subscriber data 4. finish the update location 5. Attach Accept / Attach Reject The authentication triplets are used and eventually updated if all of them have been used. This is currently accessible via the VTY interface by the following commands: - update-subscriber imsi IMSI update-auth-info - update-subscriber imsi IMSI update-location-result (ok|ERR-CAUSE) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=20d9b880e538c8728e825b4bb74ededb… commit 20d9b880e538c8728e825b4bb74ededb1a67ee20 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Mon Dec 8 15:52:00 2014 +0100 sgsn: Add support for authentication triplets This commit add data structures, functions, initialization, and VTY commands for per subscriber authentication triplets. The following VTY command is added: - update-subscriber imsi IMSI \ insert auth-triplet <1-5> sres SRES rand RAND kc KC Note that the triplets are not really used by the SGSN yet. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/doc/sgsn-remote-protocol.txt | 23 ++++--- openbsc/include/openbsc/gprs_gmm.h | 4 +- openbsc/include/openbsc/gprs_sgsn.h | 7 +- openbsc/src/gprs/gprs_gmm.c | 58 +++++++--------- openbsc/src/gprs/gprs_subscriber.c | 127 ++++++++++++++++++++++++++--------- openbsc/src/gprs/sgsn_auth.c | 45 ++++++------- openbsc/src/gprs/sgsn_vty.c | 10 ++- openbsc/tests/sgsn/Makefile.am | 2 +- openbsc/tests/sgsn/sgsn_test.c | 43 +++++++----- 9 files changed, 192 insertions(+), 127 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)