6 Nov
2014
6 Nov
'14
4:57 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards 798f3c247984a53ab8e5c68beff106b45a40b7ae (commit)
discards 41bfd4bc8731b7f6ce16f4b4097afb29b92e20bb (commit)
via 87767b2bf18fe9bcaf7954573d94dbb8547df1de (commit)
via 95e67b7a58dd3ac5e4be9d51ccce32f0047cd721 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (798f3c247984a53ab8e5c68beff106b45a40b7ae)
\
N -- N -- N (87767b2bf18fe9bcaf7954573d94dbb8547df1de)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=87767b2bf18fe9bcaf7954573d94dbb8…
commit 87767b2bf18fe9bcaf7954573d94dbb8547df1de
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 15:43:10 2014 +0100
sgsn: Don't assign a new P-TMSI if one is pending (TODO)
Currently every time a RA Update Req or an Attach Req is processed, a
new P-TMSI is alocated. When an MS issues another of these messages
before it has completed the first procedure, old_ptmsi is replaced by
ptmsi (and thus lost) and ptmsi is replaced by the newly allocated
P-TMSI. This can confuse the gbproxy, which can loose track of the
logical link then. At least a blackberry emits a double set of RA Upd
Req messages from time to time which may be just 20ms apart.
This patch adds a check whether mm->ptmsi or mm->old_ptmsi are not
both set. If both are set, the P-TMSI is not re-allocated. This is
only the case, if the Complete message has not been received since
that resets old_ptmsi.
TODO:
- Test case
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=95e67b7a58dd3ac5e4be9d51ccce32f0…
commit 95e67b7a58dd3ac5e4be9d51ccce32f0047cd721
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 13:43:41 2014 +0100
sgsn: Cleanup after RA Update Reject / Attach Reject (TODO)
Currently, the LLME is not cleanup up after sending an RA Update
Reject. This happens after entering a routing area from outside,
since in that case the SGSN sends an RA Update Reject (implicitly
detached) which causes the MS to restart the attach procedure.
The LLME is also not updated if an Attach Request with message errors
(encoding, invalid MI type) is received or if an MM context cannot be
allocated.
This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req
to unassign the LLME or free the MM context (if available) after a
Reject message has been sent.
TODO:
- test cases
Ticket: OW#1324
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gprs_gmm.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)