20 Sep
2017
20 Sep
'17
1:09 a.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 430636328c2fbd9fffc0eac5114462c200b7f2cb (commit)
from 4a31ffa2f0097d96201f80305a0495c57552f0ad (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=430636328c2fbd9fffc0eac51144…
commit 430636328c2fbd9fffc0eac5114462c200b7f2cb
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Sep 19 23:54:01 2017 +0200
fix vty regression: empty parent node
The recent exit-by-indent patch breaks a VTY case where a node is entered but
directly followed by a sibling or ancestor without listing any child nodes.
Regression introduced by I24cbb3f6de111f2d31110c3c484c066f1153aac9.
An example is a common usage in osmo-bts, where 'phy N' / 'instance N'
is a
parent node that is commonly left empty:
phy 0
instance 0
bts 0
band 1800
Before this patch, this case produces the error:
There is no such command.
Error occurred during reading the below line:
bts 0
Fix indentation parsing logic in command.c to accomodate this case.
Add a unit test for empty parent node.
Change-Id: Ia0880a17ae55accb092ae8585cc3a1bec9986891
-----------------------------------------------------------------------
Summary of changes:
src/vty/command.c | 39 +++++++++++++++++++++++++------
tests/Makefile.am | 1 +
tests/vty/{ok.cfg => ok_empty_parent.cfg} | 1 -
tests/vty/vty_test.c | 1 +
tests/vty/vty_test.ok | 2 ++
5 files changed, 36 insertions(+), 8 deletions(-)
copy tests/vty/{ok.cfg => ok_empty_parent.cfg} (66%)
hooks/post-receive
--
An utility library for Open Source Mobile Communications