osmo-pcu.git branch jerlbeck/wip/edge updated. 0.2-652-ge1f3d44

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, jerlbeck/wip/edge has been updated via e1f3d4431f77eae9fd36dbe5ff7185ef07ff7f42 (commit) via 9978e1819d0e7b7cf7738c5b8d1a847e9695c126 (commit) via 2b7928793ff42ac642f2ed1573168ef8a8aad873 (commit) via c303f5018dc0a670e83073d8166ef249f56fd0cb (commit) via 40fbd32bb258993427b457ac068f75abdb4c3cee (commit) via 86f36bb27c8628d885d06730d08e251a59868336 (commit) via 544d44df53ae3fd9a7363e696ec204c6aceca3ef (commit) via 722957a9f958495c0d452ec983b6cb541c4408e9 (commit) via 6e361335852a773d56bffbfb43f64069d32ef1d6 (commit) via b5837de15cb9c5ab75b866d47adb73ff5099a22e (commit) via 644c0a6b3a993f96d069763a70c6d5b2d2496988 (commit) via b68973d75a36c202b5055d30aa23104bf8729cea (commit) via 9f2ac1f1b2eda9a36fc52e9ddd7119db51db24ee (commit) via 05b525773ecd369115ae1f5e7fed66c6333329ec (commit) via 31b6b685f2fa069091eee40f259411310df41985 (commit) via 31acb7b95f30f8709cb40f868471ad51137f2c15 (commit) from 8a78c4d6c403763ea8260d4971b1f22cd49ffb80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=e1f3d4431f77eae9fd36dbe5ff7185e… commit e1f3d4431f77eae9fd36dbe5ff7185ef07ff7f42 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 28 19:06:09 2015 +0100 tbf/vty: Move tbf_print_vty_info to pcu_vty_functions.cpp This function is similar to the show_ms function already present in the target file. Since the TBF lists will be turned into LListHead based lists, they will get an iteration function in pcu_vty_functions.cpp, too. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=9978e1819d0e7b7cf7738c5b8d1a847… commit 9978e1819d0e7b7cf7738c5b8d1a847e9695c126 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 28 18:49:12 2015 +0100 tbf: Replace static casts by calls to as_ul_tbf/as_dl_tbf Currently casts from gprs_rlcmac_tbf to gprs_rlcmac_ul_tbf and gprs_rlcmac_dl_tbf are done by using static_cast. This doesn't provide protection against converting a gprs_rlcmac_ul_tbf pointer to a gprs_rlcmac_dl_tbf pointer and vice versa. This commit provides two functions as_ul_tbf and as_dl_tbf, that behave similar like dynamic_cast but use the direction field instead of RTTI. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=2b7928793ff42ac642f2ed1573168ef… commit 2b7928793ff42ac642f2ed1573168ef8a8aad873 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 21 15:30:18 2015 +0100 WIP: Add decoding test based on real RLC messages (TODO) http://cgit.osmocom.org/osmo-pcu/commit/?id=c303f5018dc0a670e83073d8166ef24… commit c303f5018dc0a670e83073d8166ef249f56fd0cb Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 28 14:54:08 2015 +0100 encoding: Remove RlcMacDownlink_t based write_packet_uplink_ack This is the CSN1-encoder based variant, which has been replaced and is no longer being used. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=40fbd32bb258993427b457ac068f75a… commit 40fbd32bb258993427b457ac068f75abdb4c3cee Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Dec 22 14:59:13 2015 +0100 tbf: Use bitvec based write_packet_uplink_ack (TODO) http://cgit.osmocom.org/osmo-pcu/commit/?id=86f36bb27c8628d885d06730d08e251… commit 86f36bb27c8628d885d06730d08e251a59868336 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Dec 22 14:58:34 2015 +0100 encoding: Add bitvec based write_packet_uplink_ack (TODO) http://cgit.osmocom.org/osmo-pcu/commit/?id=544d44df53ae3fd9a7363e696ec204c… commit 544d44df53ae3fd9a7363e696ec204c6aceca3ef Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 28 14:10:14 2015 +0100 sched: Assert that the generated message is not empty Currently the msg data is accessed and index 0 assuming the msg is not empty. While this should be always the case, the msg can be empty if there are software errors in the message creation functions. This commit adds an assertion to catch this kind of bugs. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=722957a9f958495c0d452ec983b6cb5… commit 722957a9f958495c0d452ec983b6cb541c4408e9 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 28 14:07:21 2015 +0100 edge: Set the EGPRS window parameters Currently the GPRS parameters are used, which is ok for the WS but not for the SNS. This commit uses RLC_EGPRS_SNS and RLC_EGPRS_MIN_WS for the window configuration. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=6e361335852a773d56bffbfb43f6406… commit 6e361335852a773d56bffbfb43f64069d32ef1d6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 28 14:01:50 2015 +0100 edge: Move EGPRS setup from setup_tbf to tbf_alloc_ul_tbf Currently the EGPRS mode is enabled in setup_tbf depending on the values of egprs_ms_class and bts->egprs_enabled (both must be != 0). This makes it difficult to set different values (like window parameters) depending on the direction. This commit moved the initialisation part to tbf_alloc_ul_tbf und just leaves the setting of the ms_class to setup_tbf. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=b5837de15cb9c5ab75b866d47adb73f… commit b5837de15cb9c5ab75b866d47adb73ff5099a22e Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 28 13:51:44 2015 +0100 rlc: Make WS and SNS variable Currently the values for WS and SNS are fixed to 64 (WS) and 128 (SNS) which are the only values that can be used with GPRS. On the other hand, EGPRS requires an SNS of 2014 and a WS in the range of 64 to 1024. This commit adds member variables and setters to both window classes. By default, the GPRS values are being used. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=644c0a6b3a993f96d069763a70c6d5b… commit 644c0a6b3a993f96d069763a70c6d5b2d2496988 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 28 13:46:32 2015 +0100 rlc: Add constructor to window classes Currently the gprs_rlc_dl_window and gprs_rlc_ul_window do not have constructors, but need to get initialized explicitly. This commit adds constructors to both classes and removes explicit external initialization code. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=b68973d75a36c202b5055d30aa23104… commit b68973d75a36c202b5055d30aa23104bf8729cea Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Dec 23 16:40:56 2015 +0100 rlc/edge: Consistently use uint16_t for BSNs and SSNs Currently in some places uint8_t is being used to encode BSNs and SSNs. This is inconsistent and (even worse) not enough for EPGRS which uses an SNS of 2014. This commit changes these to uint16_t. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=9f2ac1f1b2eda9a36fc52e9ddd7119d… commit 9f2ac1f1b2eda9a36fc52e9ddd7119db51db24ee Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Dec 23 16:29:07 2015 +0100 rlc: Add and use mod_sns(bsn) method Currently there is only a mod_sns() method which is being used in expression like bsn_expr & win.mod_sns(). This only works, because it is known that mod_sns() is (sns() - 1) where sns() in turn is always 2^n. This is error prone, hard to read, and relies on window specifics that should be kept inside the respective module. This commit adds a mod_sns(uint bsn) method to gprs_rlc_ul_window and gprs_rlc_dl_window, that encapsulates and hides this optimized computation. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=05b525773ecd369115ae1f5e7fed66c… commit 05b525773ecd369115ae1f5e7fed66c6333329ec Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 21 17:23:16 2015 +0100 edge: Support EGPRS uplink Ack/Nack messages This commit adds EGPRS UL Ack/Nack encoding based on the CSN1 code. Note that the bitmap encoding is still broken and not easy to fix with the CSN1 framework, especially w.r.t. the length field. Therefore this implementation will be abandoned and replaced by a bitvec based one. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=31b6b685f2fa069091eee40f2594113… commit 31b6b685f2fa069091eee40f259411310df41985 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 21 17:19:53 2015 +0100 rlc: Use a pointer instead of repeated selector chains Currently the same selector chain is used several times in the same function. This commit adds a pointer to Packet_Uplink_Ack_Nack and uses that instead. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/osmo-pcu/commit/?id=31acb7b95f30f8709cb40f868471ad5… commit 31acb7b95f30f8709cb40f868471ad51137f2c15 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Dec 21 15:31:13 2015 +0100 edge: Move the GPRS UL Ack/Nack encoding into a separate function (TODO) TODO: - cm ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 14 ++- src/encoding.cpp | 197 +++++++++++++++++++++++++++++++++++-------- src/encoding.h | 5 +- src/gprs_ms.cpp | 4 +- src/gprs_rlcmac_sched.cpp | 1 + src/gprs_rlcmac_ts_alloc.cpp | 12 +-- src/pcu_vty_functions.cpp | 21 +++++ src/pcu_vty_functions.h | 2 + src/rlc.cpp | 56 +++++++++--- src/rlc.h | 81 ++++++++++++++---- src/tbf.cpp | 45 +++------- src/tbf.h | 22 +++-- src/tbf_dl.cpp | 15 ++-- src/tbf_ul.cpp | 14 ++- tests/edge/EdgeTest.cpp | 28 ++++++ tests/edge/EdgeTest.ok | 2 + tests/types/TypesTest.cpp | 6 +- 17 files changed, 385 insertions(+), 140 deletions(-) hooks/post-receive -- UNNAMED PROJECT