openbsc.git branch neels/bind updated. 0.15.0-178-g1b0e554

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/bind has been updated discards 7597337ddf523f5b95c8d8d2b8ba56c4caaf759a (commit) discards ee6844b26642a6bc2a3893bc46351a17b1f40df8 (commit) discards 4d919de0b22485f211a4398ef174691739d863c4 (commit) discards c655f6bf311d4533c13309660eb5f9b2cb6c6631 (commit) discards a180f6472cfaa7d89824a7777173cd0bf5af7aa2 (commit) discards 271db46716db46adc5c65b018d11258bb7a23a03 (commit) discards 18394fdbed069f03c2c7ad910632bfba84acdc04 (commit) discards 75b580869498966c1359b7ab6588f7ac80422337 (commit) discards d5dee43a03b6f8c34460d6f7e74f5bea16d72439 (commit) discards f25f8cebb58ad1f5241a33d9bac76654cd2a68a2 (commit) via 1b0e5540dba697c9cf213e4f0aebc4baaf1618cb (commit) via 73828152d9472d5977a18491f2d9ca9b24077f43 (commit) via fc7add20e1b54e1b0d10c7457629507fb62d7d31 (commit) via f4a3123145b104fc1a6b7f17c299479a8f734918 (commit) via 0ade63233b118fdc54b404ca742f1dabb9408191 (commit) via fa0f71526c78e2f22a9a51907c40e1136e97d1e6 (commit) via 58d5430dd5d04edadb5a98532c9854d8601f801c (commit) via 127fc93a132252478e59b821665e31f2ec1df267 (commit) via 547f048c894cc3e41ca482798f9a13d814f378a5 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (7597337ddf523f5b95c8d8d2b8ba56c4caaf759a) \ N -- N -- N (1b0e5540dba697c9cf213e4f0aebc4baaf1618cb) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=1b0e5540dba697c9cf213e4f0aebc4ba… commit 1b0e5540dba697c9cf213e4f0aebc4baaf1618cb Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Wed Feb 24 19:15:39 2016 +0100 smpp: refactor initialization, add bind address Make the SMPP bind address configurable (used to be harcoded as "0.0.0.0"). Add VTY command smpp local-tcp A.B.C.D <1-65535> while keeping the old command 'local-tcp-port <1-65535>'. Both the old and the new command immediately change the SMPP listening address and port. Add a LOGL_NOTICE log when the SMPP listening address and/or port change. However, to be useful, this patch has to go somewhat further: refactor the initialization procedure, because it was impossible to run the VTY commands without an already established connection. The SMPP initialization procedure was weird. It would first open a connection on the default port, and a subsequent VTY port reconfiguration while reading the config file would try to re-establish a connection on a different port. If that failed, smpp would switch back to the default port instead of failing the program launch as the user would expect. If anything else ran on port 2775, SMPP would thus refuse to launch despite the config file having a different port: the first bind would always happen on 0.0.0.0:2775. Change that. In the VTY commands, merely store address and port if no fd is established yet. Introduce several SMPP initialization stages: * allocate struct and initialize pointers, * then read config file without immediately starting to listen, * and once the main program is ready, start listening. After that, the VTY command behaves as before: try to re-establish the old connection if the newly supplied address and port don't work out. I'm not actually sure why this switch-back behavior is needed, but fair enough. In detail, replace the function smpp_smsc_init() with the various steps smpp_smsc_alloc_init() -- prepare struct for VTY commands smpp_smsc_conf() -- set addr an port only, for reading the config file smpp_smsc_start() -- establish a first connection, for main() smpp_smsc_restart() -- switch running connection, for telnet VTY smpp_smsc_stop() -- tear down connection, used by _start() twice And replace smpp_openbsc_init() smpp_openbsc_set_net() with smpp_openbsc_alloc_init() smpp_openbsc_start() I'd have picked function names like "_bind"/"_unbind", but in the SMPP protocol there is also a bind/unbind process, so instead I chose the names "_start", "_restart" and "_stop". The smsc struct used to be talloc'd outside of smpp_smsc_init(). Since the smsc code internally uses talloc anyway and employs the smsc struct as talloc context, I decided to enforce talloc allocation within smpp_smsc_alloc_init(). Be stricter about osmo_signal_register_handler() return codes. http://cgit.osmocom.org/openbsc/commit/?id=73828152d9472d5977a18491f2d9ca9b… commit 73828152d9472d5977a18491f2d9ca9b24077f43 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Tue Feb 23 15:10:33 2016 +0100 enable ctrl bind config for various programs Add ctrl_vty_init() calls and feed the ctrl_vty_get_bind_addr() return value to ctrl_interface_setup() in the following programs: osmo-bsc osmo-bsc_nat osmo-nitb osmo-sgsn For osmo-sgsn, move the control interface setup invocation below the config parsing, so that the ctrl_vty_get_bind_addr() can return the configured address. http://cgit.osmocom.org/openbsc/commit/?id=fc7add20e1b54e1b0d10c7457629507f… commit fc7add20e1b54e1b0d10c7457629507fb62d7d31 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Tue Feb 23 14:59:43 2016 +0100 osmo-nitb: be strict about cmdline args Abort upon unknown options and missing option arguments. This came to my attention while rewiring the -m and -M options: passing -M without argument would launch nitb with wrong configuration. So, rather exit immediately. If there are legacy options that should be ignored, they deserve an own 'case:' in the option switch. There are none that I'm aware of though. http://cgit.osmocom.org/openbsc/commit/?id=f4a3123145b104fc1a6b7f17c299479a… commit f4a3123145b104fc1a6b7f17c299479a8f734918 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Tue Feb 23 14:57:22 2016 +0100 osmo-nitb: cosmetic: rename to rf_ctrl_path, following mncc_sock_path Strictly speaking, the unix domain socket location is not a name but a path. The MNCC socket is called path, so it is confusing to call the ctrl socket a 'name'. http://cgit.osmocom.org/openbsc/commit/?id=0ade63233b118fdc54b404ca742f1dab… commit 0ade63233b118fdc54b404ca742f1dabb9408191 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Tue Feb 23 14:55:17 2016 +0100 osmo-nitb: add -M to pass specific MNCC socket path The old -m option without argument is still available and marked deprecated, to not make users' lives more difficult than necessary. http://cgit.osmocom.org/openbsc/commit/?id=fa0f71526c78e2f22a9a51907c40e113… commit fa0f71526c78e2f22a9a51907c40e1136e97d1e6 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Tue Feb 23 14:09:38 2016 +0100 enable telnet VTY bind address config for various programs Following the 'line vty'/'bind A.B.C.D' command added in libosmocore, use the configured address to set the telnet bind for the VTY line. It is now possible to publish the VTY on a specific local interface (including 0.0.0.0 aka "any"). Implement in all of: osmo-gbproxy osmo-gtphub osmo-sgsn osmo-bsc osmo-bsc_nat osmo-bsc_mgcp osmo-nitb In some of these main programs, move the telnet initialization below the configuration parsing. Historically, this was not a good idea for programs using bsc_init.c (aka bsc_bootstrap_network()), since they expected a gsm_network struct pointer in ((struct telnet_connection*)vty->priv)->priv, so that telnet had to be either initialized or replaced by a dummy struct. In the meantime, the gsm_network struct is not actually looked up in a priv pointer but in the static bsc_vty.c scope (bsc_gsmnet), so this limitation is mere legacy (even though said legacy is still there in an "#if 0" chunk). In the other binaries I have briefly looked at the init sequence dependencies and found no reason to initialize telnet above the config file parsing. In any case, I have tested every single one of abovementioned binaries to verify that they still parse the example config successfully and launch, allowing VTY connections on the configured address(es). I hope this suffices. In all of the above, log VTY address and port. LOGL_INFO is disabled by default in some of the logging scopes, and since it is a single log message right at program launch, I decided for the slightly more aggressive LOGL_NOTICE. http://cgit.osmocom.org/openbsc/commit/?id=58d5430dd5d04edadb5a98532c9854d8… commit 58d5430dd5d04edadb5a98532c9854d8601f801c Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Wed Feb 24 19:30:52 2016 +0100 gsm340_rx_tpdu: comment-out two unused vars Kills two compiler warnings. http://cgit.osmocom.org/openbsc/commit/?id=127fc93a132252478e59b821665e31f2… commit 127fc93a132252478e59b821665e31f2ec1df267 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Wed Feb 24 19:29:59 2016 +0100 ipaccess_rcvmsg: fix returncode, add partial write warning Kills a compiler warning. http://cgit.osmocom.org/openbsc/commit/?id=547f048c894cc3e41ca482798f9a13d8… commit 547f048c894cc3e41ca482798f9a13d814f378a5 Author: Neels Hofmeyr &lt;nhofmeyr(a)sysmocom.de&gt; Date: Wed Feb 24 03:12:44 2016 +0100 bsc_nat: fail if VTY telnet port cannot be bound, clarify comment ----------------------------------------------------------------------- Summary of changes: openbsc/src/ipaccess/ipaccess-proxy.c | 4 ++-- openbsc/src/libmsc/gsm_04_11.c | 11 ++++++----- openbsc/src/libmsc/smpp_vty.c | 4 ++-- openbsc/src/osmo-bsc/osmo_bsc_vty.c | 4 ++-- openbsc/src/osmo-nitb/bsc_hack.c | 2 +- 5 files changed, 13 insertions(+), 12 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)