27 Feb
2018
27 Feb
'18
12:22 a.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, neels/mnc3 has been updated
discards 4615bd65427d8bd72caffb3da93f1b8bcb09d107 (commit)
discards 58c904774e33cd1c69217f000df16f7b3d739a03 (commit)
discards b834794958c3889ab963df046c780be828b44159 (commit)
discards d99e40f3e8da67576e3400592825283022720fce (commit)
discards e228f70c14acbddc474571db10df72c16c567786 (commit)
discards f4f141ef4315968f9f333ceb1d725fb54b33a5d2 (commit)
via 2b389ddd9ab23ce8e928def27e942a43dd4af4df (commit)
via 7484778e18a650ebc77c55ebd229f96ad302307f (commit)
via 322b4deae2799159130caffba64e7d204f9eb9ed (commit)
via 14e995070e632f626b41eb73f87d983ce9141d11 (commit)
via aa8e052ef9538c43940179384e85dda0ba1bc933 (commit)
via 487f9d8d9f41e5dc3c184b7bd1d71128fab8b8b9 (commit)
via 175a4ae93aaf1068b61041dca12962059d65ed55 (commit)
via 218c4de84f6d94a882e3a945332f53732bf2e134 (commit)
via 92decf2aa916353564a9dabe6871ab00e0f06a80 (commit)
via 98a7a2646bcb561b9f55b4096a0d672d4ed89c87 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (4615bd65427d8bd72caffb3da93f1b8bcb09d107)
\
N -- N -- N (2b389ddd9ab23ce8e928def27e942a43dd4af4df)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=2b389ddd9ab23ce8e928def27e94…
commit 2b389ddd9ab23ce8e928def27e942a43dd4af4df
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 15:14:14 2018 +0100
introduce GSM_MCC_MNC_INVALID
In some cases, we want to mark an unset MCC-MNC. Define uint16-max for this
purpose.
osmo-bsc code is already doing so with a -1 and using int data types, which
will become inconvenient with the new API that handles MCC and MNC as uint16_t.
Change-Id: Ieee7add0bd6d94cf84743a49794bbcd38561b72f
http://cgit.osmocom.org/libosmocore/commit/?id=7484778e18a650ebc77c55ebd229…
commit 7484778e18a650ebc77c55ebd229f96ad302307f
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 21:38:00 2018 +0100
gsm: add gsm48_mnc_from_str() and gsm48_mnc_cmp(), for 3-digit MNC
gsm48_mnc_from_str() preserves leading zeros in the string and is useful for
VTY config parsing (osmo-bsc, osmo-msc, osmo-sgsn, osmo-pcu).
gsm48_mnc_cmp() takes care of the slight intricacy of ignoring the 3-digit flag
if the MNC is anyway >99. Will be used by osmo-sgsn.git and osmo-bsc.git. (All
current users just care about identical MNC, but a proper cmp doesn't hurt.)
Change-Id: Ib7176b1d65a03b76f41f94bc9d3293a8a07d24c6
http://cgit.osmocom.org/libosmocore/commit/?id=322b4deae2799159130caffba64e…
commit 322b4deae2799159130caffba64e7d204f9eb9ed
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 22:20:42 2018 +0100
gsm0408_test: add test cases for MNC with leading zeros
Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
http://cgit.osmocom.org/libosmocore/commit/?id=14e995070e632f626b41eb73f87d…
commit 14e995070e632f626b41eb73f87d983ce9141d11
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 22:19:56 2018 +0100
gsm0408_test: test new gsm48_{decode,generate}_lai2() functions
Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
http://cgit.osmocom.org/libosmocore/commit/?id=aa8e052ef9538c43940179384e85…
commit aa8e052ef9538c43940179384e85dda0ba1bc933
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 15:12:23 2018 +0100
gsm0408_test: check for new mnc_3_digits flag
Note that on the input side, the 3-digits flag may be left false when the MNC
is >99 anyway. On the decoded side, the flag is set accurately.
Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c
http://cgit.osmocom.org/libosmocore/commit/?id=487f9d8d9f41e5dc3c184b7bd1d7…
commit 487f9d8d9f41e5dc3c184b7bd1d71128fab8b8b9
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Tue Feb 20 13:47:08 2018 +0100
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
actually different; so far we treated both as 23. Re-encode an incoming BCD or
string of 023 as it were, i.e. not dropping the leading zero as 23.
Break ABI compatibility by changing the size and ordering of struct gprs_ra_id.
Ordering is changed because the canonical oder is {Mobile Country Code, Mobile
Network Code}, so have the mcc member first. Change size (and ordering) by
inserting a flag to indicate a three-digit MNC after the mnc member. ABI
compatibility cannot be maintained, since struct gprs_ra_id is a direct member
of structs bssgp_bvc_ctx and bssgp_paging_info, and even just adding a flag to
the end would cause ABI changes of those structs.
Add new API to set and read this additional flag to preserve leading zeros:
- gsm48_mcc_mnc_to_bcd2(), gsm48_mcc_mnc_from_bcd2() after
gsm48_mcc_mnc_to_bcd() and gsm48_mcc_mnc_from_bcd().
- gsm0808_create_layer3_aoip2() after gsm0808_create_layer3_aoip().
- gsm48_decode_lai2(), gsm48_generate_lai2() after
gsm48_decode_lai(), gsm48_generate_lai().
- The equivalent of gsm0808_create_layer3() for preserving leading zeros is
gsm0808_create_layer3_aoip2() with the scl argument passed as NULL; instead
of introducing a new shim function like gsm0808_create_layer3_2(), indicate
such in the API docs, only.
- gsm48_mnc_from_str() to encode leading zeros from string, useful for VTY
config parsing.
- gsm48_mnc_cmp() to compare MNC values including leading zeros.
- various osmo_*_name() functions. The amount and seeming duplication of these
may seem a bit overboard, but IMO they do make sense in this way. The root
reason is that the use of MCC and MNC is quite diverse throughout the osmocom
code base: in certain code, they are single uint16_t, in others they are
embedded in structs along with lac and rac; sometimes, all should be printed
in one go (repeatedly), in other cases (vty, ctrl) they are required singled
out. Without these functions, the formatting kind of ("%0*u", mnc_3_digits
?
3 : 2, mnc) would be duplicated all over our diverse repositories, or
printing MCC-MNC or RAI would otherwise end up to be more code.
In various log output, include the leading MNC zeros.
Mark one TODO in card_fs_sim.c, I am not sure how to communicate a leading zero
to/from a SIM card FS. The focus here is on the core network / BSS.
To indicate ABI incompatibility, bump libosmogsm and libosmogb LIBVERSIONs;
adjust debian files accordingly.
Implementation choices:
- The default behavior upon zero-initialization will be the mnc_3_digits flag
set to false, which yields exactly the previous behavior.
- I decided against packing the mnc with the mnc_3_digits field into a
sub-struct because it would enlarge this patch; plus, with a separate flag,
current code can decide when to start heeding leading zeros.
Change-Id: Id2240f7f518494c9df6c8bda52c0d5092f90f221
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/core/rate_ctr.h | 9 +++++++++
include/osmocom/ctrl/ports.h | 3 +++
include/osmocom/gsm/gsm48.h | 1 -
include/osmocom/vty/ports.h | 2 ++
src/gsm/gsm48.c | 16 ----------------
src/gsm/libosmogsm.map | 1 -
src/vty/fsm_vty.c | 12 ++++++++++++
7 files changed, 26 insertions(+), 18 deletions(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications