openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-917-g0ee763f

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 70992b3369bb8922d92aabdbd54a33d3a52d8c05 (commit) discards 0153212b910a6c01103e1f4dc914457ac733bd9c (commit) discards 7d08477daa44919b65bbbaa794947e70bc88e407 (commit) discards 8f4a1762c82e25093de13c30fd58d0b3645c8e9f (commit) discards 78198111ebf1f60fb369a9788b5f8045d9b0beb8 (commit) discards c3f158e84846fc1fbd58aa0e377acd12a78d29ab (commit) discards 3b928ed5ed7e93144714fbe4e332ef04769d0b08 (commit) discards 34287fbf01125845844f84de7e6111e77d137775 (commit) via 0ee763fe1b99390f23eb62cc86d1848e89cdbeb4 (commit) via 97113dccfc7af33e7443e1086932306718f87554 (commit) via b2186d39d547280a73ff24cc0a4d657301cd0cc4 (commit) via 367e17ab4fac2388bba6329101fce721fcec28ca (commit) via 5bb5439eaf769bc63159df1875e11da158695f69 (commit) via 5d2620dd4a233dafcf1c8e170a0934521e3ae8ba (commit) via 01a346c7320c9f9eceae8245d75700242cf65151 (commit) via 09283010307a88941f1c47746bbdce29e0e3b783 (commit) via 612ecee1666fc6d42eebbeda73e21bd86740023b (commit) via 90a5ed8f6b53e8a3f84e4d80d74ef5a308ec0ec2 (commit) via fdb18e8c191648abe1b9f1393157b106d8d03c1b (commit) via c735ef9a098d94bd2a3451f7004855bcf973fe91 (commit) via d5d594fcc93a7719bd1a64d51e9c10e331f2a43d (commit) via a1f0dd1e5193556b9cdfb57dead27457230f4415 (commit) via 925c57fb545b072159a831bff852c92795704dfe (commit) via 1ba0730a7109b06e4043e7b17c11d8d2c34358c5 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (70992b3369bb8922d92aabdbd54a33d3a52d8c05) \ N -- N -- N (0ee763fe1b99390f23eb62cc86d1848e89cdbeb4) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=0ee763fe1b99390f23eb62cc86d1848e… commit 0ee763fe1b99390f23eb62cc86d1848e89cdbeb4 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=97113dccfc7af33e7443e10869323067… commit 97113dccfc7af33e7443e1086932306718f87554 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b2186d39d547280a73ff24cc0a4d6573… commit b2186d39d547280a73ff24cc0a4d657301cd0cc4 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=367e17ab4fac2388bba6329101fce721… commit 367e17ab4fac2388bba6329101fce721fcec28ca Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Jan 29 14:55:34 2015 +0100 sgsn/test: Add checks for subscr->error_cause This commits adds a few asserts that check the value of subscr->error_cause after a GSUP message has been received. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5bb5439eaf769bc63159df1875e11da1… commit 5bb5439eaf769bc63159df1875e11da158695f69 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Jan 29 14:17:51 2015 +0100 gprs: Use 'Network failure' as default cause This commit adds a check after a GSUP message has been decoded whether it is an error message and does not contain a cause value. If his is the case, the cause value is set to 'Network failure', so that this cause if effectively the default value for error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5d2620dd4a233dafcf1c8e170a093452… commit 5d2620dd4a233dafcf1c8e170a0934521e3ae8ba Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Jan 29 14:15:54 2015 +0100 gprs/test: Fix GSUP Purge MS response messages Currently the message types for these message types are wrong. This patch inserts the correct message types. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=01a346c7320c9f9eceae8245d7570024… commit 01a346c7320c9f9eceae8245d75700242cf65151 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Jan 29 14:12:29 2015 +0100 sgsn/test: Add tests for PurgeMs responses Currently there are not any test cases for PurgeMS GSUP messages in test_subscriber_gsup. This commit adds tests for incoming PurgeMSResult and -Error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=09283010307a88941f1c47746bbdce29… commit 09283010307a88941f1c47746bbdce29e0e3b783 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Jan 29 14:00:28 2015 +0100 gprs: Send GSUP error reply for requests without IMSI (TODO) Currently gprs_subscr_rx_gsup_message returns immediately after it detects that an IMSI has not been given in the received GSUP message. While this is ok for responses (result or error), a request should always be answered. This commit adds code to reply with a corresponding error message ("Invalid mandatory information") when it receives a request without an IMSI. Note that the generated error message will not contain an IMSI, too. TODO: - add logging Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=612ecee1666fc6d42eebbeda73e21bd8… commit 612ecee1666fc6d42eebbeda73e21bd86740023b Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Thu Jan 29 11:36:35 2015 +0100 gprs: Extend specification of GSUP cause values (TODO) Currently, every error message contains a mandantory Cause IE just referring to GSM 04.08 for further details. This leaves the mapping from MAP User Errors to GMM Cause values undefined. It is also not specified, which GMM Cause to assume, if no User Error has been included in the MAP message. This commit makes the Cause IE conditional, it is only required if the MAP message contained a User Error. A mapping from User Errors to GMM Causes is also added. The default value for GMM Causes in GSUP error messages is now 'Network failure' to keep the impact low. TODO: - the mapping is not finished, it needs review and some values are not yet specified. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=90a5ed8f6b53e8a3f84e4d80d74ef5a3… commit 90a5ed8f6b53e8a3f84e4d80d74ef5a308ec0ec2 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Tue Jan 27 14:56:40 2015 +0100 gprs: Support cancellation type The cancellation type that is part of the UpdateCancellation message is currently ignored. This patch adds the missing glue between the existing GSUP and GMM support. If the type is not present or has the value updateProcedure the subcriber and MM context are siliently removed. Otherwise, a message with cause 'implicitly detached' is sent to the MS. Since the real cause is not known (the specification neither added a cause IE nor defined a static cause value), the MS may get the real cause in the following AttachRej. Added VTY commands: - update-subscriber imsi IMSI cancel update-procedure - update-subscriber imsi IMSI cancel subscription-withdraw the old form without the cause is no longer supported. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fdb18e8c191648abe1b9f1393157b106… commit fdb18e8c191648abe1b9f1393157b106d8d03c1b Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Tue Jan 27 13:47:24 2015 +0100 gprs: Handle PURGE MS ERR/RES without subscr Currently the subscr entry is no longer present, when PURGE MS ERROR/RESULT arrives. In this case, an unspecific notice is logged ('unknown IMSI'). This clutters up the logfile with notices even in perfectly normal operation. This commit changes the code path that is used when a subscr cannot be found for an incoming GSUP message. A check for PURGE MS RESULT and ERROR is added and gprs_subscr_handle_gsup_purge_no_subscr is called for these messages instead of gprs_subscr_handle_unknown_imsi. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c735ef9a098d94bd2a3451f7004855bc… commit c735ef9a098d94bd2a3451f7004855bcf973fe91 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Tue Jan 27 12:41:19 2015 +0100 gprs: Don't use subscr->keep_in_ram in normal operation Currently the keep_in_ram flag is explicitely reset in gprs_subscr_cleanup to cover the case, that the VTY 'create' sub-command has been used to create the subscriber entry. This commit completely removes keep_in_ram handling from gprs_subscriber.c and adds a VTY 'destroy' sub-command to reset the flag and remove the entry. So 'create' and 'destroy' can be used to manager sticky entries that are kept even when a location cancellation is done. Added VTY command: - update-subscriber imsi IMSI destroy Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d5d594fcc93a7719bd1a64d51e9c10e3… commit d5d594fcc93a7719bd1a64d51e9c10e331f2a43d Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Mon Jan 26 14:43:07 2015 +0100 sgsn: Add sgsn_mm_ctx_cleanup_free for safe shutdown Currently the MM context cleanup code is distributed over several functions. sgsn_mm_ctx_free not only frees data structure but also eventually stops the timer and does the subscriber clean-up. mm_ctx_cleanup_free (gprs_gmm.c) cleans up the PDP contexts and unassign the TLLI. This commit moves the cleanup code from both functions into a new unifying function sgsn_mm_ctx_cleanup_free that cares about the clean-up of all related sub-systems. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a1f0dd1e5193556b9cdfb57dead27457… commit a1f0dd1e5193556b9cdfb57dead27457230f4415 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Mon Jan 26 13:52:42 2015 +0100 sgsn: Don't allow mmctx == NULL in sgsn_update_subscriber_data Currently, sgsn_update_subscriber_data can be called with mmctx == NULL and will find and associate the right context (if present) based on the subscriber's IMSI. This will not happen in regular use any more, since sgsn_update_subscriber_data will only be called when subscribers are used (auth mode 'remote') and in this case gprs_subscr_get_or_create_by_mmctx will already be called by sgsn_auth_request. Therefore, MM context and subscriber are always associated except for some test cases and experimental VTY usage. The current implementation of sgsn_update_subscriber_data also causes additional complexity for the deletion on MM contexts to avoid a ipossible double-free MM contexts. This commit removes the MM context <-> subscriber association code from sgsn_update_subscriber_data. That function must always be called with mmctx != NULL, now. To avoid problems with VTY and test usage, the calling subscriber function now only call sgsn_update_subscriber_data when mmctx != NULL, since the purpose of that function is to update that state of an existing MM context after subscriber data has been changed. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/doc/sgsn-remote-protocol.txt | 77 +++++++++++++++++++++++++++---- openbsc/include/openbsc/gsm_data.h | 1 + openbsc/include/openbsc/vty.h | 1 + openbsc/src/gprs/gprs_subscriber.c | 11 ++++- openbsc/src/libbsc/net_init.c | 2 + openbsc/src/libcommon/common_vty.c | 1 + openbsc/src/libmsc/gsm_04_08.c | 29 ++++++++---- openbsc/src/libmsc/vty_interface_layer3.c | 47 +++++++++++++++++++ openbsc/tests/gprs/gprs_test.c | 4 +- openbsc/tests/sgsn/sgsn_test.c | 37 +++++++++++++++ 10 files changed, 187 insertions(+), 23 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)