30 Aug
2016
30 Aug
'16
2:30 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, sysmocom/revert_WAIT_ASSIGN has been updated
discards a4fd319f8408946a9b5824c8cd081be92527e6d6 (commit)
via 2d0da6371dba88860d843998faabd98518d50179 (commit)
via fd713841046e4a8f0b67e1e794cc046367a0174c (commit)
via b11919899295889b577a9f9ada71935e437ff8d8 (commit)
via 01826c13b1139db70f14b14e18ab35ac4646c872 (commit)
via 959d1dee67e1c6fcfc57b347be2fb7a2ed099b2d (commit)
via eebcb1e3e87a37cde3ac6aaf89b8c6c201abb6ba (commit)
via 02352b487ac6808b6adb8e8623f0921aad7f02d7 (commit)
via 50b097003baac3903c9d52a609b091c76ca83e3c (commit)
via e6cadb4e3ccd05673fd9d33f8a445dd54be6006b (commit)
via 1ec4d80176680a99d561a19adee9677756e65d99 (commit)
via 9876f4bb211341ad3cefe5505b30694b04ee91e7 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (a4fd319f8408946a9b5824c8cd081be92527e6d6)
\
N -- N -- N (2d0da6371dba88860d843998faabd98518d50179)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=2d0da6371dba88860d843998faabd98…
commit 2d0da6371dba88860d843998faabd98518d50179
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Jun 8 15:27:40 2016 +0200
Revert "tbf: Add state WAIT_ASSIGN"
This reverts commit f1a7b8fc6651f92a8b7f3f27b7ca05d07f4e44e0.
Conflicts:
tests/tbf/TbfTest.err
The commit broke GPRS service at least for osmo-bts-sysmo on a SysmoBTS 1002
with current master of osmo-bts (ef30f50d5d6d5f863fc147d05ccdceb89284934e).
The error observed is the following log output (was viewing both osmo-bts-sysmo
and osmo-pcu logs interleaved):
<0002> tbf.cpp:874 TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=WAIT ASSIGN) T3169
timeout during transsmission
<0002> tbf.cpp:893 - Assignment was on CCCH
<0002> tbf.cpp:899 - No uplink data received yet
<0007> l1sap.c:904 RACH for packet access
<0001> pcu_l1_if.cpp:311 RACH request received: sapi=1 qta=0, ra=121, fn=13653
[repeat]
When removing this single commit from current osmo-pcu master, GPRS service
works well on SysmoBTS, with current osmo-bts master.
The TbfTest.err expected output needed adjustment after the revert.
Disclaimer: I am not aware of adverse effects this commit may have. I have no
idea what the WAIT_ASSIGN state is used for -- further review is required.
Change-Id: I1532f8e93194368cdc1e3846f82afa6d68cd5fbd
-----------------------------------------------------------------------
Summary of changes:
contrib/jenkins.sh | 9 -
src/bts.cpp | 3 +-
src/bts.h | 8 +-
src/encoding.cpp | 3 +-
src/gprs_coding_scheme.h | 8 +-
src/pcu_l1_if.cpp | 3 +-
src/pcu_main.cpp | 9 +-
src/pcu_vty.c | 30 ++-
src/pcuif_proto.h | 8 +-
src/rlc.cpp | 31 ++-
src/rlc.h | 52 ++++-
src/tbf.h | 5 +
src/tbf_dl.cpp | 219 +++++++++++++++---
tests/edge/EdgeTest.cpp | 38 +--
tests/tbf/TbfTest.cpp | 422 +++++++++++++++++++++++++++++++++-
tests/tbf/TbfTest.err | 583 +++++++++++++++++++++++++++++++++++++++++++++--
tests/tbf/TbfTest.ok | 8 +
17 files changed, 1330 insertions(+), 109 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT