openbsc.git branch neels/auth_tests_wip updated. 0.15.0-201-g7d8ea8b

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/auth_tests_wip has been updated discards 20bbcd096de9156fcbfc61950cde46cd20236ec3 (commit) discards 48123874f7877de5e163f83593aa193c2fc6ad96 (commit) discards 36f9af92b0d94126efe38c9dfc786ea155516356 (commit) discards b4eda53768ebefbad6bfe5231e562b77f233fc2d (commit) discards 1a92af94a272e6f52508e84820f248069b9a6acc (commit) discards 51f510ab12e76ad07ccaf9ac42ab6309c96528fc (commit) via 7d8ea8bb5abad91c1d5aeb8d447fd92fe6bcb652 (commit) via 131b6f2ee5ad820fd0a3c715b26eacd71673d509 (commit) via 95b8adbd5ea2010b24807cdc89895bbab0f6bf0e (commit) via bd7dd6ba922bf87d9a2a5e8b8a499e0dce6f5b3d (commit) via 1f2c4ba3cefeef9dede5fae19de88fa0f896574b (commit) via 0bdd1fda17a36567ea9b1b3073adedea4c2f5780 (commit) via 23b1bc36045c2bbdb3cb6ddab0e7ee87b2fcbfcc (commit) via 56ea30ff3f9f98a4903d060196b185ce124d7eaa (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (20bbcd096de9156fcbfc61950cde46cd20236ec3) \ N -- N -- N (7d8ea8bb5abad91c1d5aeb8d447fd92fe6bcb652) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=7d8ea8bb5abad91c1d5aeb8d447fd92f… commit 7d8ea8bb5abad91c1d5aeb8d447fd92fe6bcb652 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 14:01:57 2016 +0100 Fix MM Auth: zero-initialize auth tuple before first use Make sure a new auth tuple is initialized after db_get_lastauthtuple_for_subscr() returns an error. In effect, the first key_seq used no longer depends on how the auth tuple was initialized before the call. Before this patch, the first key_seq depended on the value was present in auth tuple's key_seq. http://cgit.osmocom.org/openbsc/commit/?id=131b6f2ee5ad820fd0a3c715b26eacd7… commit 131b6f2ee5ad820fd0a3c715b26eacd71673d509 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 13:44:38 2016 +0100 Fix MM Auth: disallow key_seq mismatch In auth_get_tuple_for_subscr(), add missing condition to match incoming key_seq with stored key_seq, so that re-authentication is requested for mismatching key_seqs. Add test for this issue. http://cgit.osmocom.org/openbsc/commit/?id=95b8adbd5ea2010b24807cdc89895bba… commit 95b8adbd5ea2010b24807cdc89895bbab0f6bf0e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:41:08 2016 +0100 MM Auth: return AUTH_NOT_AVAIL instead of hardcoded zero AUTH_NOT_AVAIL == 0, so this is no functional change. http://cgit.osmocom.org/openbsc/commit/?id=bd7dd6ba922bf87d9a2a5e8b8a499e0d… commit bd7dd6ba922bf87d9a2a5e8b8a499e0dce6f5b3d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:39:47 2016 +0100 MM Auth: introduce AUTH_ERROR constant. Instead of using hardcoded -1 for errors, include -1 in the enum auth_action type; apply its use. In effect remove a compiler warning recently introduced in auth_action_str() about int value not represented in enum definition. In the mm_auth test, the string output changes from '(internal error)' to 'AUTH_ERROR'. http://cgit.osmocom.org/openbsc/commit/?id=1f2c4ba3cefeef9dede5fae19de88fa0… commit 1f2c4ba3cefeef9dede5fae19de88fa0f896574b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 12:10:48 2016 +0100 MM Auth test: add test to re-use existing auth http://cgit.osmocom.org/openbsc/commit/?id=0bdd1fda17a36567ea9b1b3073adedea… commit 0bdd1fda17a36567ea9b1b3073adedea4c2f5780 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:26:09 2016 +0100 MM Auth test: add two tests for AUTH_THEN_CIPH Test two situations for AUTH_DO_AUTH_THEN_CIPH: - when no auth tuple is available - when the key sequence from LU is marked invalid Add convenience auth tuple comparison function using stringification. http://cgit.osmocom.org/openbsc/commit/?id=23b1bc36045c2bbdb3cb6ddab0e7ee87… commit 23b1bc36045c2bbdb3cb6ddab0e7ee87b2fcbfcc Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Mar 26 01:21:00 2016 +0100 Add MM Auth test; add auth_action_str() function Add basic MM Authentication test setup, with fake DB access and RAND_bytes(). So far implement simple tests for IO error during DB access and missing auth entry. To print the auth action during tests, implement auth_action_str() inline function. ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/auth.h | 5 +- openbsc/src/libmsc/auth.c | 12 +++- openbsc/tests/mm_auth/mm_auth_test.c | 103 ++++++++++++++++++++++------------ openbsc/tests/mm_auth/mm_auth_test.ok | 18 +++++- 4 files changed, 98 insertions(+), 40 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)