17 Mar
2016
17 Mar
'16
6:09 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/patches-pending has been updated
discards 1c02de7ae89ce1996dd52898f5dd36eae9532739 (commit)
discards c1eb1fcd5378897b6d1818481b5d0ea08cd73511 (commit)
discards a8e0f01025fff784d904531305807cb00dc579b2 (commit)
discards 9760079bfcf7f8b3783ec536485b255b7a8397ce (commit)
discards 530414d77e6f22c109257496cd0e1f1249acb06e (commit)
via df9770abad644f320c9c2f27847ee63fef3f63b8 (commit)
via 3ad0346f00c4d135f7d4d15017ce2941e13e2c54 (commit)
via 044fbe6568f82a12bf4e3addc7e3d6db529b6548 (commit)
via d2fa7a509a989bb775b56932502d128ec974330d (commit)
via f4afcf0b2345a51d3e69c4dbb61279af233388cf (commit)
via 10cd11345c2dd3f38793e7dd7456e7882ab95dd9 (commit)
via 8c515272c3e82c2400b15b5bfefa9dd883b86b96 (commit)
via 961bd0b121d604612ea27bd2c83edd73290b2cb6 (commit)
via 531734a547f16de08ce94ec64d58cf94c2230893 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (1c02de7ae89ce1996dd52898f5dd36eae9532739)
\
N -- N -- N (df9770abad644f320c9c2f27847ee63fef3f63b8)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=df9770abad644f320c9c2f27847ee63f…
commit df9770abad644f320c9c2f27847ee63fef3f63b8
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Mon Mar 7 17:19:19 2016 +0100
Remove unused auth code and add comment
As commented in the code, the GSM_SECURITY_AUTH_FAILED path is never invoked by
the gsm48_secure_channel() function as it is today.
Note that the upcoming Iu auth will probably add a GSM_SECURITY_AUTH_FAILED
status. In that case, sending a LU Reject immediately may be desirable, but
arguably a bit of timeout could make life harder for auth attackers.
The code removed by this patch doesn't send out a LU Reject ever, since a call
to release_loc_updating_req() only releases the connection. To reject, a call
to gsm0408_loc_upd_rej() would be necessary, as seen in loc_upd_rej_cb().
And finally, if _gsm0408_authorize_sec_cb() doesn't do anything about anything,
the same loc_upd_rej_cb() will be run by a timeout and send a LU Reject
properly (as commented in the code).
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libmgcp/mgcp_transcode.c | 8 ++++----
openbsc/src/utils/meas_db.c | 13 ++-----------
2 files changed, 6 insertions(+), 15 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)